User tests: Successful: Unsuccessful:
For consistency, capitalize "Hide all messages" button in toolbar.
Click Post Installation Messages button.
See capitalization in button of toolbar.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
?
|
RTC
Please read the style guide and correct https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html
So the “all” should be lowercase because of “Do not capitalise joining words and words of three characters or less such as and, to, for.”. Sure we fulfill that everywhere?
Status | Ready to Commit | ⇒ | Pending |
Back to pending.
I would say All
has significance here vs. to
, for
, etc. So you are ok with this?
Hide all Messages
or change to Hide Messages
?
I'm not a native speaker and did not know our style guide in detail, so I hope @brianteeman can advise further.
Here are some strings with All
.
COM_ASSOCIATIONS_PURGE="Delete All Associations"
COM_ACTIONLOGS_EXPORT_ALL_CSV="Export All as CSV"
COM_CATEGORIES_CATEGORIES_VIEW_DEFAULT_TITLE="List All Categories"
I had the same in mind and so to me this PR seemed to be ok as it is, also according to capitalization rules of famous newspapers who capitalize “All” in their titles.
But I don’t wanna argue with native speakers as I am not one.
Status | Pending | ⇒ | Ready to Commit |
Back to RTC due to @Quy 's findings above. See also e.g. https://capitalizemytitle.com/ , which suggest "Hide All Messages" in all available modes. They (and also other sources) say that pronouns are capitalized, and "All" is a kind of pronoun. I assume the Joomla style guide describes the rule in a (too much and so wrong?) simplified way and possibly needs to be corrected.
all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox
all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox
@brianteeman So if the word "all" shall not be capitalized in titles or labels, why did you then make this PR? #34416 ... it seems you only care for style guides when it concerns PR's of other people but not yours.
because it is different when there are only two words eg Check for Updates
because it is different when there are only two words eg Check for Updates
@brianteeman Is that described somewhere in our style guide? I can't find anything about that here: https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html
@brianteeman so what are you saying it should be? Hide all Messages
I assume from the styleguide page? It looks a bit weird to me but if that's at least consistent it is what it is
@brianteeman Please respond to @wilsonge 's question above #34765 (comment) with respect to consistency with @Quy 's findings here #34765 (comment) .
Labels |
Added:
?
Language Change
?
Removed: ? ? |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-08 17:31:36 |
Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 1d7aba0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.