? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
12 Jul 2021

Summary of Changes

For consistency, capitalize "Hide all messages" button in toolbar.

Testing Instructions

Click Post Installation Messages button.
See capitalization in button of toolbar.

avatar Quy Quy - open - 12 Jul 2021
avatar Quy Quy - change - 12 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2021
Category Administration Language & Strings
avatar richard67 richard67 - test_item - 12 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 12 Jul 2021

I have tested this item successfully on 1d7aba0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

avatar ChristineWk ChristineWk - test_item - 12 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 12 Jul 2021

I have tested this item successfully on 1d7aba0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

avatar richard67 richard67 - change - 12 Jul 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 12 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

avatar brianteeman
brianteeman - comment - 12 Jul 2021
avatar richard67
richard67 - comment - 12 Jul 2021

So the “all” should be lowercase because of “Do not capitalise joining words and words of three characters or less such as and, to, for.”. Sure we fulfill that everywhere?

avatar richard67 richard67 - change - 12 Jul 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 12 Jul 2021

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

avatar Quy
Quy - comment - 12 Jul 2021

I would say All has significance here vs. to, for, etc. So you are ok with this?

Hide all Messages

avatar Quy
Quy - comment - 12 Jul 2021

or change to Hide Messages?

avatar richard67
richard67 - comment - 12 Jul 2021

I'm not a native speaker and did not know our style guide in detail, so I hope @brianteeman can advise further.

avatar Quy
Quy - comment - 12 Jul 2021

Here are some strings with All.

COM_ASSOCIATIONS_PURGE="Delete All Associations"
COM_ACTIONLOGS_EXPORT_ALL_CSV="Export All as CSV"
COM_CATEGORIES_CATEGORIES_VIEW_DEFAULT_TITLE="List All Categories"

avatar richard67
richard67 - comment - 12 Jul 2021

I had the same in mind and so to me this PR seemed to be ok as it is, also according to capitalization rules of famous newspapers who capitalize “All” in their titles.

avatar richard67
richard67 - comment - 12 Jul 2021

But I don’t wanna argue with native speakers as I am not one.

avatar richard67 richard67 - change - 13 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Jul 2021

Back to RTC due to @Quy 's findings above. See also e.g. https://capitalizemytitle.com/ , which suggest "Hide All Messages" in all available modes. They (and also other sources) say that pronouns are capitalized, and "All" is a kind of pronoun. I assume the Joomla style guide describes the rule in a (too much and so wrong?) simplified way and possibly needs to be corrected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34765.

avatar brianteeman
brianteeman - comment - 13 Jul 2021

all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox

avatar richard67
richard67 - comment - 13 Jul 2021

all those sources are for US english!! But do what you want. Styleguides seem optional in joomla and only relevant when the sun is in the vernal equinox

@brianteeman So if the word "all" shall not be capitalized in titles or labels, why did you then make this PR? #34416 ... it seems you only care for style guides when it concerns PR's of other people but not yours.

avatar brianteeman
brianteeman - comment - 13 Jul 2021

because it is different when there are only two words eg Check for Updates

avatar richard67
richard67 - comment - 13 Jul 2021

because it is different when there are only two words eg Check for Updates

@brianteeman Is that described somewhere in our style guide? I can't find anything about that here: https://developer.joomla.org/en-gb-user-interface-text-guidelines/capitalisation.html

avatar wilsonge
wilsonge - comment - 13 Jul 2021

@brianteeman so what are you saying it should be? Hide all Messages I assume from the styleguide page? It looks a bit weird to me but if that's at least consistent it is what it is

avatar Quy
Quy - comment - 13 Jul 2021

delete-all-associations

export-all

avatar richard67
richard67 - comment - 25 Aug 2021

@brianteeman Please respond to @wilsonge 's question above #34765 (comment) with respect to consistency with @Quy 's findings here #34765 (comment) .

avatar wilsonge wilsonge - change - 8 Sep 2021
Labels Added: ? Language Change ?
Removed: ? ?
avatar wilsonge wilsonge - change - 8 Sep 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-09-08 17:31:36
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Sep 2021
avatar wilsonge wilsonge - merge - 8 Sep 2021
avatar wilsonge
wilsonge - comment - 8 Sep 2021

Thanks!

Add a Comment

Login with GitHub to post a comment