Joomla! Issue Tracker | Joomla! CMS #34760 - [4.0] Add target

? ? ?

Fixed in Code Base
12 Jul 2021
Medium
Build: 4.0-dev
# 34760
Diff
Quy:target-blank

Pending

User tests: Successful: Unsuccessful:

Quy
11 Jul 2021

Summary of Changes

Add icon to indicate link is external.

Testing Instructions

Go to Post Installation Messages
See links with external icon.

2123c3e 11 Jul 2021

Add target _blank

Quy - open - 11 Jul 2021

Quy - change - 11 Jul 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 11 Jul 2021

Category

⇒

Administration Language & Strings

Quy - change - 11 Jul 2021

Title

…

[4.0] Add target _blank

[4.0] Add target _blank to display icon link as external

Quy - edited - 11 Jul 2021

brianteeman - comment - 11 Jul 2021

if you're going to change it then you also need to add the noreferrer stuff

7e7cdc9 12 Jul 2021

Add noopener noreferrer

Quy - change - 12 Jul 2021

Labels

Added: ? ?

f0adaa8 12 Jul 2021

Add noopener noreferrer

hans2103 - test_item - 12 Jul 2021 - Tested successfully

hans2103 - comment - 12 Jul 2021

I have tested this item ✅ successfully on f0adaa8

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

sandewt - test_item - 12 Jul 2021 - Tested successfully

sandewt - comment - 12 Jul 2021

I have tested this item ✅ successfully on f0adaa8

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

sandewt - comment - 12 Jul 2021

Oops, missing here: noopener noreferrer

<a href="https://en.wikipedia.org/wiki/Google_Authenticator" target="_blank">Google Authenticator</a>

hans2103 - comment - 12 Jul 2021

Oops, missing here: noopener noreferrer

<a href="https://en.wikipedia.org/wiki/Google_Authenticator" target="_blank">Google Authenticator</a>

out of scope for this PR.
Language string for this post-install message comes from plg_system_httpheaders.ini

joomla-cms/administrator/language/en-GB/plg_system_httpheaders.ini

Line 56 in 4730efc

    
           PLG_SYSTEM_HTTPHEADERS_POSTINSTALL_INTRODUCTION_BODY="<p>Joomla! comes with a built-in set of tools that help you to handle http security headers. These headers help your browser for example to protect your website from <a href='https://en.wikipedia.org/wiki/Cross-site_scripting' target='_blank' rel='noopener noreferrer'>XSS</a> and <a href='https://en.wikipedia.org/wiki/Clickjacking' target='_blank' rel='noopener noreferrer'>Clickjacking</a> attacks.</p><p>You can find more details in the <a href='https://docs.joomla.org/Special:MyLanguage/J4.x:Http_Header_Management' target='_blank' rel='noopener noreferrer'>HTTP Header Management Tutorial in the Joomla! Documentation.</a></p>"

And already contains noopener noreferrer

sandewt - comment - 12 Jul 2021

out of scope for this PR.

I agree.

I see that this problem also occurs with the external links under the help function.

sandewt - comment - 12 Jul 2021

And already contains noopener noreferrer

I agree, apparently something went wrong for me when I upgraded to J 4.0.0-rc3 !?

richard67 - comment - 12 Jul 2021

I agree, apparently something went wrong for me when I upgraded to J 4.0.0-rc3 !?

@sandewt So is your successful test still valid or not?

richard67 - test_item - 12 Jul 2021 - Tested successfully

richard67 - comment - 12 Jul 2021

I have tested this item ✅ successfully on f0adaa8

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

richard67 - change - 12 Jul 2021

Status

Pending

⇒

Ready to Commit

richard67 - comment - 12 Jul 2021

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

sandewt - comment - 12 Jul 2021

@hans2103 / @richard67

It concerns the plg_twofactorauth_totp.ini and NOT the plg_system_httpheaders.ini

See: missing noopener noreferrer

joomla-cms/administrator/language/en-GB/plg_twofactorauth_totp.ini

Line 11 in 4730efc

    
           PLG_TWOFACTORAUTH_TOTP_POSTINSTALL_BODY="<p>Joomla! comes with a built-in two factor authentication system. It secures your site login with a secondary secret code that's changing every 30 seconds. You can use your mobile device and the <a href=\"https://en.wikipedia.org/wiki/Google_Authenticator\" target=\"_blank\">Google Authenticator</a> app to produce that code.</p><p>By selecting the button below:</p><ul><li>Joomla! will enable the two factor authentication plugins</li><li>Two Factor Authentication is going to be available for all users.</li><li>Each user can configure Two Factor Authentication in User Details.</li><li>You can always disable Two Factor Authentication plugin, or configure it for Backend usage only.</li><li>You will be taken to your user profile page where you can find more information on two factor authentication and enable it for your user account.</li></ul>"

out of scope for this PR.

So I think, this is not out of the scope

@sandewt So is your successful test still valid or not?

richard67 - comment - 12 Jul 2021

See: missing noopener noreferrer

joomla-cms/administrator/language/en-GB/plg_twofactorauth_totp.ini

Line 11 in 4730efc

PLG_TWOFACTORAUTH_TOTP_POSTINSTALL_BODY="<p>Joomla! comes with a built-in two factor authentication system. It secures your site login with a secondary secret code that's changing every 30 seconds. You can use your mobile device and the <a href=\"https://en.wikipedia.org/wiki/Google_Authenticator\" target=\"_blank\">Google Authenticator</a> app to produce that code.</p><p>By selecting the button below:</p><ul><li>Joomla! will enable the two factor authentication plugins</li><li>Two Factor Authentication is going to be available for all users.</li><li>Each user can configure Two Factor Authentication in User Details.</li><li>You can always disable Two Factor Authentication plugin, or configure it for Backend usage only.</li><li>You will be taken to your user profile page where you can find more information on two factor authentication and enable it for your user account.</li></ul>"

out of scope for this PR.

So I think, this is not out of the scope

@sandewt So is your successful test still valid or not?

NO

@Quy Should we fix this in staging or here?

hans2103 - comment - 12 Jul 2021

Created a PR in this PR
Because discussing about it takes more time than fixing it.
Quy#3

sandewt - comment - 12 Jul 2021

Because discussing about it takes more time than fixing it.

richard67 - comment - 12 Jul 2021

Well I had noticed that but I thought the reason why it has not been made in this PR was because it should be fixed in staging.

brianteeman - comment - 12 Jul 2021

With the language string freeze tomorrow it will need to happen here

96cb627 12 Jul 2021

add rel=\"noopener noreferrer\" to plg_twofactorauth_totp.ini (#3)

Quy - change - 12 Jul 2021

Labels

Added: ?

Quy - comment - 12 Jul 2021

#24337 discusses this issue globally for J4.

@HLeithner will have to decide if for J3.

richard67 - test_item - 12 Jul 2021 - Tested successfully

richard67 - comment - 12 Jul 2021

I have tested this item ✅ successfully on 96cb627

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

richard67 - comment - 12 Jul 2021

@hans2103 Could you test again? Thanks in advance.

hans2103 - test_item - 12 Jul 2021 - Tested successfully

hans2103 - comment - 12 Jul 2021

I have tested this item ✅ successfully on 96cb627

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34760.}

richard67 - comment - 12 Jul 2021

2 good tests, so RTC is valid again.

zero-24 - change - 12 Jul 2021

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2021-07-12 16:17:45
Closed_By		⇒	zero-24
Labels	Added: ? Removed: ?

zero-24 - close - 12 Jul 2021

zero-24 - merge - 12 Jul 2021

zero-24 - comment - 12 Jul 2021

Merging

HLeithner - comment - 12 Jul 2021

#24337 discusses this issue globally for J4.

@HLeithner will have to decide if for J3.

sandewt - comment - 12 Jul 2021

See: missing noopener noreferrer (occurs twice)

<a href=\"https://freeotp.github.io/\" target=\"_blank\">FreeOTP</a>

https://github.com/Quy/joomla-cms/blob/96cb627464c0f415b42c8fd4187451c45122062e/administrator/language/en-GB/plg_twofactorauth_totp.ini#L24

@Quy

[EDIT]

Quy - comment - 15 Jul 2021

@sandewt This PR fixed only external links in the Post Installation Messages page. There are other instances like the ones you mentioned to be fixed in a separate PR to address #24337.

sandewt - comment - 15 Jul 2021

@Quy , thanks for your explanation.

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#34760] - [4.0] Add target _blank to display icon link as external

Summary of Changes

Testing Instructions

Add a Comment