? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
10 Jul 2021

Pull Request for Issue #34730 .

Summary of Changes

Alternative to #34737 - the post installation module hardcodes loading the english file - this shouldn't be required - just load the native language file.

Testing Instructions

Install a language such as french and navigate to the post-installation messages page

Actual result BEFORE applying this Pull Request

Screenshot 2021-07-10 at 18 29 23

Expected result AFTER applying this Pull Request

Screenshot 2021-07-10 at 18 29 36

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 10 Jul 2021
avatar wilsonge wilsonge - change - 10 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2021
Category Modules Administration
avatar wilsonge wilsonge - change - 10 Jul 2021
Title
Don't load hardcoded English language file in post installation messa…
[4.0] Don't load hardcoded English language file in post installation messa…
avatar wilsonge wilsonge - edited - 10 Jul 2021
avatar Quy Quy - test_item - 10 Jul 2021 - Tested successfully
avatar Quy
Quy - comment - 10 Jul 2021

I have tested this item successfully on ff66fee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar richard67 richard67 - test_item - 10 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 10 Jul 2021

I have tested this item successfully on ff66fee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar richard67 richard67 - change - 10 Jul 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 10 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar ChristineWk ChristineWk - test_item - 10 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 10 Jul 2021

I have tested this item successfully on ff66fee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar brianteeman brianteeman - test_item - 10 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Jul 2021

I have tested this item successfully on ff66fee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar ChristineWk
ChristineWk - comment - 10 Jul 2021

:-)

screen shot 2021-07-10 at 18 01 27


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

Oh, I was too late.

avatar richard67
richard67 - comment - 10 Jul 2021

Oh, I was too late.

@ChristineWk More test are never bad ? .. especially for strange languages ?

avatar ChristineWk
ChristineWk - comment - 10 Jul 2021

@richard67
ik hou van nederlandse taal :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34752.

avatar Quy Quy - close - 10 Jul 2021
avatar Quy Quy - merge - 10 Jul 2021
avatar Quy Quy - change - 10 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-10 19:06:16
Closed_By Quy
Labels Added: ?
avatar Quy
Quy - comment - 10 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment