Pull Request for Issue # .

Summary of Changes

This reverts PR #34608 "Fix metismenu caret wrapping" because it has broken styling of the active menu item.

The PR has added a span between the li element and the link but did not adjust existing SCSS for this, so the parent selectors &. don't match anymore for the menu item types modified by that PR. Instead of correcting SCSS that PR has added more SCSS, which leads to redundant hardly maintainable code, and the additional SCSS is not complete.

As a result of this, at least the styling of the active menu item has been broken by that PR.

It can be that the PR has broken more based on parent selectors which don't match anymore, but I haven't tested everything. RTL could be one thing, especially for menu items of level 3 or more.

Therefore it is the best to revert that PR for now.

Testing Instructions

Make a new installation and then install Sample Data Blog.

After that, create a few copies of the Main Menu Blog and put them on different positions. Change the layout from "collapsible-dropdown" to "dropdown" for the copies, and for some of them use menu class "menu-horizontal".

Then check if a menu item with a link (i.e. type "URL" or "Component") is underlined when it is active or one of its submenu items is active, like is it done with the menu items without link (type "Heading" or "Separator").

Actual result BEFORE applying this Pull Request

While the active menu item and its parents are underlined underlined when the menu item is of a type without a link (type "Heading" or "Separator"), this doesn't happen when the menu item is of a type with a link (i.e. type "URL" or "Component") which have been modified by PR #34608 .

See the red marks in the following screenshot:

As said, for menu items without a link which have not been modified by PR #34608 it works:

The above screenshots shows examples top menu items because that's the most visible thing, but of course parent menu items at lower levels should work the same.

Expected result AFTER applying this Pull Request

All types of menu items and their parents are underlined (with a pseudo element in the header and with text decoration elsewhere) in the same way when they are the active menu item.

The following screenshot shows the example for a top menu item because that's the most visible thing, but of course parent menu items at lower levels should work the same.

Documentation Changes Required

None.