Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34746] - [4.0] Fix menu export

? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
10 Jul 2021

Pull Request for Issue #34700 .

Summary of Changes

Fix menu export feature

Testing Instructions

Apply patch and please follow #34700

Actual result BEFORE applying this Pull Request

Export not works

Expected result AFTER applying this Pull Request

Export works

Documentation Changes Required

None

avatar Fedik Fedik - open - 10 Jul 2021
avatar Fedik Fedik - change - 10 Jul 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2021
Category ⇒ Administration com_menus
avatar Kostelano Kostelano - test_item - 10 Jul 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 10 Jul 2021

I have tested this item ✅ successfully on 862dcf5

Thanks, the button is working.

Note that a warning is available in the export file. This is probably not related to this solution, but please check your export files - those who will be testing the PR.

<br />
<b>Warning</b>:  SimpleXMLElement::addChild(): unterminated entity reference task=getMenuBadgeData&amp;format=json&quot;,&quot;menu-anchor_title&quot;:&quot;&quot;,&quot;menu_icon&quot;:&quot;&quot;,&quot;menu_image&quot;:&quot;&quot;,&quot;menu_image_css&quot;:&quot;&quot;,&quot;menu_text&quot;:1,&quot;menu_show&quot;:1} in <b>C:\OSPanel\domains\joomla4\administrator\components\com_menus\src\View\Menu\XmlView.php</b> on line <b>172</b><br />
<?xml version="1.0"?>
<menu xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="urn:joomla.org" xsi:schemaLocation="urn:joomla.org menu.xsd">
  <menuitem type="component" title="&#x421;&#x43E;&#x43E;&#x431;&#x449;&#x435;&#x43D;&#x438;&#x44F; &#x43F;&#x43E;&#x441;&#x43B;&#x435; &#x443;&#x441;&#x442;&#x430;&#x43D;&#x43E;&#x432;&#x43A;&#x438;" link="index.php?option=com_postinstall&amp;view=messages" element="com_postinstall" class=" " access="1">
    <params/>
  </menuitem>
  <menuitem type="heading" title="&#x437;&#x430;&#x433;&#x43E;&#x43B;" link="#" class=" " access="1">
    <params>{"menu-anchor_title":"","menu_icon":"","menu_image":"","menu_image_css":"","menu_text":1,"menu_show":1,"dashboard":"131"}</params>
  </menuitem>
</menu>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34746.
avatar Fedik Fedik - change - 10 Jul 2021
Labels Added: ?
avatar Fedik
Fedik - comment - 10 Jul 2021

@Kostelano please test again, should be good now, with UTF-8 and stuff

avatar Kostelano Kostelano - test_item - 10 Jul 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 10 Jul 2021

I have tested this item ✅ successfully on 8d66f54

Everything is fine now, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34746.

avatar chmst chmst - test_item - 10 Jul 2021 - Tested successfully
avatar chmst
chmst - comment - 10 Jul 2021

I have tested this item ✅ successfully on 8d66f54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34746.

avatar chmst chmst - change - 10 Jul 2021
Status Pending ⇒ Ready to Commit
avatar chmst
chmst - comment - 10 Jul 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34746.

avatar wilsonge wilsonge - change - 10 Jul 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-07-10 13:21:58
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Jul 2021
avatar wilsonge wilsonge - merge - 10 Jul 2021
avatar wilsonge
wilsonge - comment - 10 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment