NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar pinak3748
pinak3748
5 Jul 2021

Pull Request for Issue # .

Summary of Changes

On every page which has status column in which the status icon was not properly aligned in mobile view.
The order icon was going below the status.

it is same issue as #34709

Testing Instructions

  • Firstly, run npm ci in order to compile new SCSS changes

and

  • You need to have some entry on every page that has a status column.

Actual result BEFORE applying this Pull Request

before

Expected result AFTER applying this Pull Request

after

avatar pinak3748 pinak3748 - open - 5 Jul 2021
avatar pinak3748 pinak3748 - change - 5 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2021
Category Administration Templates (admin) NPM Change
avatar pinak3748 pinak3748 - change - 5 Jul 2021
The description was changed
avatar pinak3748 pinak3748 - edited - 5 Jul 2021
avatar Quy
Quy - comment - 5 Jul 2021

Thank you for the PR, however, this is already fixed in #34714.

avatar Quy Quy - close - 5 Jul 2021
avatar Quy Quy - change - 5 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-05 16:25:19
Closed_By Quy
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 5 Jul 2021

Sorry @pinak3748 as you closed it without a replacement I did it.

avatar pinak3748
pinak3748 - comment - 5 Jul 2021

i thought you said to create a new pr so that's why i closed it

avatar pinak3748
pinak3748 - comment - 5 Jul 2021

no worry it was fun working on real production.

Add a Comment

Login with GitHub to post a comment