? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
5 Jul 2021

Pull Request for Issue # .

Summary of Changes

Thanks @brianteeman for the hint.

The commonly used icon for accessibility is the wheel chair icon.
But this is not suitable for web accessibility. Now we can use the universal-access icon instead.

Testing Instructions

Apply the patch, run npm

The easy way: Replace any icon in inspector by "icon-accessible" as for example here
grafik

Or open any layout (example administrator\modules\mod_login\tmpl\default.php)
and replace an icon by icon-accessible (for example the icon-eye)

Actual result BEFORE applying this Pull Request

icon-accessible
grafik

Expected result AFTER applying this Pull Request

grafik

@hans2103 Could not replace the icon in Jicons-brand, moved to $icons

accessible : $fa-var-accessible-icon

avatar chmst chmst - open - 5 Jul 2021
avatar chmst chmst - change - 5 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2021
Category Repository NPM Change
avatar brianteeman brianteeman - test_item - 5 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Jul 2021

I have tested this item successfully on 626c1a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34713.

avatar hans2103 hans2103 - test_item - 5 Jul 2021 - Tested successfully
avatar hans2103
hans2103 - comment - 5 Jul 2021

I have tested this item successfully on 626c1a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34713.

avatar alikon alikon - change - 5 Jul 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34713.

avatar Quy Quy - change - 5 Jul 2021
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-05 15:19:35
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 5 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment