Feeling Lucky
?
?
[#34711] - [4.0] Empty Trash button in clients and newsfeed
- Fixed in Code Base
- 5 Jul 2021
- Medium
- Build: 4.0-dev
- # 34711
- Diff
- rjharishabh:empty-banner
User tests: Successful: Unsuccessful:
Summary of Changes
Add !$this->isEmptyState when adding toolbar->delete()
It's similar to PR #34619
Testing Instructions
For clients
- Add a client (if you don't have any)
- Trash the client
- Delete the client
and repeat the same for newsfeeds.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_newsfeeds |
Quy
- comment
- 5 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34711.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 5 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34711.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-05 22:25:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 5 Jul 2021
Thanks!
rjharishabh
- comment
- 6 Jul 2021
Thanks!
I have tested this item✅ successfully on 0b731da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34711.