? Success

User tests: Successful: Unsuccessful:

avatar zero-24 zero-24 - open - 17 Apr 2014
avatar zero-24 zero-24 - change - 17 Apr 2014
Title
[3.x] Fix failing manifest updates
[#33626] [3.x] Fix failing manifest updates
avatar zero-24 zero-24 - reference | f5f916b - 17 Apr 14
avatar mbabker
mbabker - comment - 17 Apr 2014

Are you sure removing the OR statement is appropriate? I can't tell right
now because I'm on mobile, but IIRC, that's needed because the query is
being built in a foreach loop.

On Thursday, April 17, 2014, zero-24 notifications@github.com wrote:

Tracker:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33626&start=0

You can merge this Pull Request by running

git pull https://github.com/zero-24/joomla-cms patch-17

Or view, comment on, or merge it at:

#3471
Commit Summary

  • Fix failing manifest updates

File Changes

Patch Links:


Reply to this email directly or view it on GitHub#3471
.

avatar zero-24
zero-24 - comment - 17 Apr 2014

@mbabker
ok. But least the last stament is wrong as it contains a "or" without a statment. Or i'm wrong here?

avatar mbabker
mbabker - comment - 17 Apr 2014

Since it's using JDatabaseQuery to build it, the OR won't be there on the
last loop if the where() function is called properly.

On Thursday, April 17, 2014, zero-24 notifications@github.com wrote:

@mbabker https://github.com/mbabker
ok. But least the last stament is wrong as it contains a "or" without a
statment. Or i'm wrong here?


Reply to this email directly or view it on GitHub#3471 (comment)
.

avatar zero-24
zero-24 - comment - 17 Apr 2014

hmm ok so why the manifest update fails?

avatar mbabker
mbabker - comment - 17 Apr 2014

Without being in front of a computer to test, couldn't tell you. Just
going off the top of my head at the moment.

On Thursday, April 17, 2014, zero-24 notifications@github.com wrote:

hmm ok so why the manifest update fails?


Reply to this email directly or view it on GitHub#3471 (comment)
.

avatar zero-24 zero-24 - close - 17 Apr 2014
avatar zero-24
zero-24 - comment - 17 Apr 2014

hmm ok @mbabker so i closing here as it not fix the issue correct.

avatar zero-24 zero-24 - change - 17 Apr 2014
Title
[3.x] Fix failing manifest updates
[#33626] [3.x] Fix failing manifest updates
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-04-17 15:18:18
Labels Added: ? ?
avatar zero-24 zero-24 - close - 17 Apr 2014
avatar zero-24 zero-24 - head_ref_deleted - 17 Apr 2014

Add a Comment

Login with GitHub to post a comment