? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
3 Jul 2021

Summary of Changes

The workflow selection has no context set, so in the futur if other extensions want to use the workflow, wrong information could be displayed.

Testing Instructions

If you activate the workflow and go to the category, there is a workflow selection.
After applying the PR, the field works like before.

2nd test:

Create a new workflow, go to the database and change the context to "com_banners.banner". The new workflow shouldn't be visible anywhere in com_content now.

avatar bembelimen bembelimen - open - 3 Jul 2021
avatar bembelimen bembelimen - change - 3 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2021
Category Administration com_content
avatar brianteeman
brianteeman - comment - 3 Jul 2021

Maybe this will help to solve #31324

avatar bembelimen
bembelimen - comment - 3 Jul 2021

Hello Brian,
thanks for checking.
This PR solved another problem:
You can simulate a 2nd extension using the workflow by creating a new workflow and then go into the database and change the context in the database to e.g. "com_banners.banner".
The the new workflow should disappear everywhere from com_content.

avatar bembelimen bembelimen - change - 3 Jul 2021
The description was changed
avatar bembelimen bembelimen - edited - 3 Jul 2021
avatar brianteeman
brianteeman - comment - 3 Jul 2021

I realised it was for a different issue - just wondered if it would help to resolve that one. Probably should have drunk a coffee and tried it before posting

avatar bembelimen bembelimen - change - 3 Jul 2021
Labels Added: ?
avatar bembelimen
bembelimen - comment - 3 Jul 2021

I realised it was for a different issue - just wondered if it would help to resolve that one. Probably should have drunk a coffee and tried it before posting

chmst#13 I sent an update for @chmst PR

avatar Quy Quy - test_item - 6 Jul 2021 - Tested successfully
avatar Quy
Quy - comment - 6 Jul 2021

I have tested this item successfully on b9cc78e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34692.

avatar RickR2H RickR2H - test_item - 7 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 7 Jul 2021

I have tested this item successfully on b9cc78e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34692.

avatar richard67 richard67 - change - 7 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34692.

avatar chmst chmst - change - 7 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-07 15:11:19
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 7 Jul 2021
avatar chmst chmst - merge - 7 Jul 2021
avatar chmst
chmst - comment - 7 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment