[#3467] - [#32568] JoomlaUpdate fails if remember me plugin is enabled.
- Closed
- 11 Aug 2014
- Medium
- Build: staging
- # 3467
- Diff
- Bakual:FixRememberUpgrade
- Foreign ID 32568
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
There are some reports that the remember me plugin causes the Joomla Updater to hang on the last step. That is due to a fatal error produced:
Fatal error: Call to a member function isAdmin() on a non-object in /.../plugins/system/remember/remember.php on line 42
The problem is that this only happens on some enviroments and on others it works fine.
It may be related to the order in which the files are replaced with the new ones during the update.
While JPlugin in 3.2 does populate $this->app automatically, this wasn't the case in earlier versions. I think that this is the problem we see here since we are in an undefined state regarding the Joomla version.
Solution
This PR adds a check if $this->app is populated and if not it will get the Application.
Testing Instructions
Of course make sure nothing breaks and the remember me still works as expected. Nothing should change here.
If you can reproduce the issue with the Joomla Updater, try with a patched zip and see if it works.
Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32568
| Title |
|
||||||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-11 16:02:48 |
Merged since George did the same PR as well and it will not break anything.
Sophist-UK
-
I just had this plugin updating from Joomla 2.5.22 to Joomla 3.3.1. I deleted the plugin folder after getting the warning screen then refreshed and all was OK. Not sure if deleting the plugin will cause issues.
You may blame the J!Tracker Application for transmitting this comment.