? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
29 Jun 2021

Summary of Changes

composer update --no-dev

Lock file operations: 0 installs, 4 updates, 0 removals

  • Upgrading joomla/archive (1.1.8 => 1.1.10)
  • Upgrading joomla/filter (1.4.3 df3403c => 1.4.3 ec95176)
  • Upgrading leafo/lessphp (dev-joomla3-php8 1bddadb => dev-joomla3-php8 a149187)
  • Upgrading psr/log (1.1.3 => 1.1.4)

Testing Instructions

Make sure the following packages still work:

  • joomla/filter
  • lessphp (generation of less files from within the template manager)
  • joomla/archive (upload + install an extension)
  • psr/log

Actual result BEFORE applying this Pull Request

non up-to-date packages

Expected result AFTER applying this Pull Request

up-to-date packages

Documentation Changes Required

none

@brianteeman that should look better now.

avatar zero-24 zero-24 - open - 29 Jun 2021
avatar zero-24 zero-24 - change - 29 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2021
Category External Library Composer Change Libraries
avatar brianteeman
brianteeman - comment - 29 Jun 2021

Looking at the changed files in this pr there are no changes in the leafo/lessphp files

avatar zero-24
zero-24 - comment - 29 Jun 2021

Yes cause the last commit to that repo is a file (Readme; joomla-backports/lessphp#6) thats not included in the packaged build here from my understanding.

avatar brianteeman
brianteeman - comment - 29 Jun 2021

I can see the composer lock changes so thats ok

avatar HLeithner HLeithner - change - 29 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-29 20:22:54
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 29 Jun 2021
avatar HLeithner HLeithner - merge - 29 Jun 2021
avatar HLeithner
HLeithner - comment - 29 Jun 2021

Thanks

avatar HLeithner
HLeithner - comment - 30 Jun 2021

@zero-24 did you tested this pr? because it seems autoloader is broken. the file platform_check.php is missing

avatar zero-24
zero-24 - comment - 30 Jun 2021

I have just run the mentiond command to see that i have not an broken composer update again. I have not yet tested the changes itself. While i'm supprised when that file does not exist cause i have 'just' updated the packages and not changed something internal within composer atleast not intentional.

avatar HLeithner
HLeithner - comment - 30 Jun 2021

yeah it's a bit tricky, it seems you missed to add the new files that composer added. I created the #34659 pr and hopefully it will fix it.

avatar chrisdavenport
chrisdavenport - comment - 30 Jun 2021

I'm not seeing platform_check.php in that PR. All our automated tests are currently failing because that file is missing.

avatar HLeithner
HLeithner - comment - 30 Jun 2021

@chrisdavenport as mentioned above #34659 fixes this issue

avatar chrisdavenport
chrisdavenport - comment - 30 Jun 2021

Thanks @HLeithner I can confirm that it does indeed fix the issue.

avatar zero-24
zero-24 - comment - 30 Jun 2021

yeah it's a bit tricky, it seems you missed to add the new files that composer added. I created the #34659 pr and hopefully it will fix it.

Thanks sorry for creating that mess..

Add a Comment

Login with GitHub to post a comment