Issues in Joomla 4.0 rc3-dev!
Just did a clone from Git an noticed that some functionality from TinyMCE are broken.
Did you composer install and npm ci?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34649.
Yes I did! A clean install of the 4.0-dev branche.
Did you composer install and npm ci?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34649.Yes I did! A clean install of the 4.0-dev branche.
@RickR2H @chmst hasn’t asked if you made a clean installation, she has asked if you have run composer and npm.
Did you composer install and npm ci?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34649.Yes I did! A clean install of the 4.0-dev branche.
@RickR2H @chmst hasn’t asked if you made a clean installation, she has asked if you have run composer and npm.
True, but you have to run composer and npm ci to get the installation to work.
Did you composer install and npm ci?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34649.Yes I did! A clean install of the 4.0-dev branche.
@RickR2H @chmst hasn’t asked if you made a clean installation, she has asked if you have run composer and npm.
True, but you have to run composer and npm ci to get the installation to work.
@RickR2H Not necessarily if the branch hasn’t been cleaned up from previous, older results of these commands after having checked out or pulled.
@richard67 It was a git pull from the J! repo. After switching the branche to 4.0-dev I dit composer install and npm ci. That's what I ment with clean. Did an other run of composer and npm just to be sure. Same result.
Confirmed
Uncaught TypeError: Cannot read property 'tooltip' of null
at g (tinymce-builder.min.js?9822b7ae5b380d2f620c8f583b70a843:1)
at Object.h.TinyMCEBuilder (tinymce-builder.min.js?9822b7ae5b380d2f620c8f583b70a843:1)
at HTMLDocument.<anonymous> (tinymce-builder.min.js?9822b7ae5b380d2f620c8f583b70a843:1)
I have repeated clean installation on win10, xampp PHP 7.4 and php8.0 without problem.
Until clearing browser cache ... then i could reproduce
I'll try a nightly when I back on my PC.
@RickR2H @brianteeman What’s your npm and node versions?
C:\htdocs\joomla-cms>npm -v
7.16.0
C:\htdocs\joomla-cms>node -v
v14.15.2
Hmm versions should be new enough.
If you can't test with the brand new RC 3 in an empty folder for some reason, issue following commands in a command window on your local git clone after having checked out and pulled the 4.0-dev branch:
git clean -d -x -f
git checkout .
git pull origin 4.0-dev
(assuming the remote is named "origin").
The first command removes all files and folder not being tracked by git and not being mentioned in the .gitignore file.
The second command reverts all modifications to files tracked by git.
The third commands pulls changes from remote.
After that, do again
composer install
npm ci
And then make again a new installation.
If that or the new 4.0 TC 3 package works, then there was some compiled/compressed/gzipped js leftover from past which causes the issues.
If all that does not work then we can be more sure that we have an issue.
P.S.: And clear browser cache to be sure having gotten rid of old cached js.
Hmm ... less weird but still weird ... next step would be to format hard disk ...
remind me how to do that again ;)
I can reproduce what @brianteeman reported back on a clean, current 4.0-dev branch after composer install and npm ci, cleared browser cache and closed browser session:
Tested with latest version of Firefox and Google Chrome, both on Windows 10.
I can reproduce what @brianteeman reported back on a clean, current 4.0-dev branch after composer install and npm ci, cleared browser cache and closed browser session:
Confirmed! Same result... On Windows 10 + Chrome
Ah I was too fast, you wrote it already.
@brianteeman does the path in the "Content Template Directory" work in your installation?
the icons missed due to #34472
Joomla.sanitize()
applied to icons:
joomla-cms/build/media_source/plg_editors_tinymce/js/tinymce-builder.es6.js
Lines 283 to 285 in ca4670a
@dgrammatiko could you take a look?
Ping @dgrammatiko
Could this also be related to the "Content Template Directory" path?
@brianteeman does the path in the "Content Template Directory" work in your installation?
Yes it works
Check to make sure that the folder exists
as the js issue was to fix a release blocker and it clearly created this issue then this should be a release blocker
the icons missed due to #34472
Joomla.sanitize()
applied to icons:joomla-cms/build/media_source/plg_editors_tinymce/js/tinymce-builder.es6.js
Lines 283 to 285 in ca4670a
The sanitizer can have a second argument (array of objects) to extend the supported elements and the safe attributes. I’ll do a pr
EDIT: PR: #34654
Labels |
Added:
J4 Issue
?
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-30 06:10:35 |
Closed_By | ⇒ | alikon | |
Labels |
Added:
Language Change
Removed: ? |
Labels |
Removed:
Language Change
|
@richard67 @brianteeman Update regarding the "Content Template Directory" path. I did some extensive testing and I noticed that in a live site environment I can select the path "cassiopeia/html/tinymce" on my local WAMP server I just get "- Use Default -". So the issue is related to my local env, The problem is that is is just a clean WAMP installation with no fancy tweaks. So probably more people should have the same problem. Maybe it is an issue with how the Content Tenplate path is required from the server that only works om some configurations?
Do you guys have some tips on where to look and how to investigate the issue?
I normally use Linux servers for testing but will later see if I can reproduce it on one of my Windows environments.
On the other hand, as far as I know @brianteeman uses Windows, so it should not be Windows specific problem.
correct - i am on windows
I normally use Linux servers for testing but will later see if I can reproduce it on one of my Windows environments.
On the other hand, as far as I know @brianteeman uses Windows, so it should not be Windows specific problem.
Thanks Richard! I'll also do some more investigation. Let me know it it works on your env. @brianteeman which WAMP install do you use?
I use native apache and php etc
@brianteeman @richard67 Did some extensive testing and can confirm that is was pure my local installation. Thanks for your patience and feedback.
@brianteeman looks like the "Content Template Directory" path work now but setting it is has no effect in the editor, Only the default templates show up in the template selector. Also setting a custom editor CSS in TinyMCE doesn't seems to work. Could you confirm my findings? If so, I'll open a new issue. Thanks!
are you sure you didnt fall into the trap of forgetting that those settings apply only to the selected set. So if you are a super admin you would need to move to the third tab (set 0) and make the settings there
@brianteeman never noticed that all te settings apply to every set differently! Thanks for pointing me in the right direction!
Did you composer install and npm ci?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34649.