[#34645] - Get finder plugin id from memory intstead of the db
- Fixed in Code Base
- 2 Jul 2021
- Medium
- Build: 4.0-dev
- # 34645
- Diff
- sakiss:getFinderPluginId
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The function getFinderPluginId is called more than once in the com_finder component (e.g. called both in the controller and the view in the same cycle). There is no need to query the database for something already fetched.
Testing Instructions
- Disable the "Smart Search Content Plugin".
- Check the warning message at the top of the Smart Search component.
- Click the link with the plugin name, in the warning to open the plugin's modal.
Actual result BEFORE applying this Pull Request
Click the link in the warning to open the plugin's modal.
Expected result AFTER applying this Pull Request
Click the link in the warning to open the plugin's modal.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34645.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34645.
Shouldn't we use our existing library method https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Extension/ExtensionHelper.php#L422 for this task? Something like
ExtensionHelper::getExtensionRecord('finder', 'plugin', 0, 'content')->extension_id;
Shouldn't we use our existing library method https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Extension/ExtensionHelper.php#L422 for this task? Something like
ExtensionHelper::getExtensionRecord('finder', 'plugin', 0, 'content')->extension_id;
@joomdonation The PR intents to improve the existing logic. You can create a new PR for changing the logic completely.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-30 09:51:45 |
| Closed_By | ⇒ | sakiss | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-06-30 09:51:45 | ⇒ | |
| Closed_By | sakiss | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
RTC again after it has been closed by the author by accident, it seems.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34645.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-02 07:21:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Merging this as it’s clearly an improvement but @joomdonation youre right - definitely would be happy to see a PR using the library method
I have tested this item✅ successfully on e86933d
Popup still works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34645.