? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
28 Jun 2021

Pull Request for wilsonge#69 (comment) .

Summary of Changes

With PR #34289 folders /bin and /libraries/vendor/bin have been removed from the list of folders to be deleted on update in script.php because these folders might contain files or subfolders added by the site admin.

For /libraries/vendor/bin this was wrong because that folder is maintained by composer and completely cleared on the development environment when doing a composer install.

See also the comment here wilsonge#69 (comment) .

This PR here corrects this by adding that folder back.

As that folder has been removed from the installation and update packages with 4.0 RC 1, the folder is added back to section 4.0 from Beta 7 to RC 1 like it was before PR #34289 .

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

No folder /libraries/vendor/bin in section 4.0 from Beta 7 to RC 1 of the $folders array in method deleteUnexistingFiles of file administrator/components/com_admin/script.php.

Expected result AFTER applying this Pull Request

Folder /libraries/vendor/bin in section 4.0 from Beta 7 to RC 1 of the $folders array in method deleteUnexistingFiles of file administrator/components/com_admin/script.php.

Hint: Folders within a version specific section are ordered reverse alphabetical.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 28 Jun 2021
avatar richard67 richard67 - change - 28 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2021
Category Administration com_admin
avatar Fedik Fedik - test_item - 28 Jun 2021 - Tested successfully
avatar Fedik
Fedik - comment - 28 Jun 2021

I have tested this item successfully on cbb7e62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

avatar wojsmol wojsmol - test_item - 28 Jun 2021 - Tested successfully
avatar wojsmol
wojsmol - comment - 28 Jun 2021

I have tested this item successfully on cbb7e62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

avatar richard67 richard67 - change - 28 Jun 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 28 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

avatar richard67 richard67 - change - 28 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 28 Jun 2021
avatar wilsonge wilsonge - close - 29 Jun 2021
avatar wilsonge wilsonge - merge - 29 Jun 2021
avatar wilsonge wilsonge - change - 29 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-29 07:46:27
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 29 Jun 2021

Thanks!

avatar richard67
richard67 - comment - 29 Jun 2021

Thanks all.

Add a Comment

Login with GitHub to post a comment