User tests: Successful: Unsuccessful:
Pull Request for wilsonge#69 (comment) .
With PR #34289 folders /bin
and /libraries/vendor/bin
have been removed from the list of folders to be deleted on update in script.php because these folders might contain files or subfolders added by the site admin.
For /libraries/vendor/bin
this was wrong because that folder is maintained by composer and completely cleared on the development environment when doing a composer install.
See also the comment here wilsonge#69 (comment) .
This PR here corrects this by adding that folder back.
As that folder has been removed from the installation and update packages with 4.0 RC 1, the folder is added back to section 4.0 from Beta 7 to RC 1
like it was before PR #34289 .
Code review.
No folder /libraries/vendor/bin
in section 4.0 from Beta 7 to RC 1
of the $folders
array in method deleteUnexistingFiles
of file administrator/components/com_admin/script.php
.
Folder /libraries/vendor/bin
in section 4.0 from Beta 7 to RC 1
of the $folders
array in method deleteUnexistingFiles
of file administrator/components/com_admin/script.php
.
Hint: Folders within a version specific section are ordered reverse alphabetical.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-29 07:46:27 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Thanks all.
I have tested this item✅ successfully on cbb7e62
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.