Feeling Lucky
?
?
[#34619] - [4.0] Remove Empty Trash button in empty state in com_contact
- Fixed in Code Base
- 2 Jul 2021
- Medium
- Build: 4.0-dev
- # 34619
- Diff
- rjharishabh:trash
User tests: Successful: Unsuccessful:
Summary of Changes
Add !$this->isEmptyState when adding toolbar->delete()
Testing Instructions
- Add a contact (if you don't have any)
- Trash the contact
- Delete the contact
cont.mp4
Actual result BEFORE applying this Pull Request
Empty Trash button in Emptystate
Expected result AFTER applying this Pull Request
No Empty Trash button in Emptystate
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
rjharishabh
- comment
- 24 Jun 2021
You only have the button because the last action you performed (deleting) used a filter and the filter doesn't get reset on use.
This behaviour most likely exists everywhere so if you're going to address it here then you should do so everywhere.
yes, I've tested in banners and categories, it's not there but there are lots which have to correct
| Title |
|
||||||
Kostelano
- comment
- 29 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34619.
Quy
- comment
- 29 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34619.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 Jun 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34619.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-02 13:12:14 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 2 Jul 2021
Thanks
You only have the button because the last action you performed (deleting) used a filter and the filter doesn't get reset on use.
This behaviour most likely exists everywhere so if you're going to address it here then you should do so everywhere.