? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jun 2021

Content versions for an article has a button to indicate if the version should be kept forever or not.

However it is incorrectly an a link designed to look like a button but not act like a button.

If the action is to take you to a new page then its a link - otherwise its a button.

A button can be activated with both the space and enter keys. A link just by the enter key.

BONUS: This also fixes #34592

image

avatar brianteeman brianteeman - change - 24 Jun 2021
Status New Pending
avatar brianteeman brianteeman - open - 24 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2021
Category Administration com_content com_contenthistory
avatar ChristineWk ChristineWk - test_item - 24 Jun 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Jun 2021

I have tested this item successfully on 476acda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34614.
<button type="button" class="btn btn-secondary btn-sm active" onclick="return Joomla.listItemTask('cb0','history.keep')"> Yes &nbsp;<span class="icon-lock" aria-hidden="true"></span> </button>

avatar ricardo1709 ricardo1709 - test_item - 24 Jun 2021 - Tested successfully
avatar ricardo1709
ricardo1709 - comment - 24 Jun 2021

I have tested this item successfully on 476acda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34614.

avatar chmst chmst - change - 24 Jun 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 24 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34614.

avatar wilsonge wilsonge - close - 27 Jun 2021
avatar wilsonge wilsonge - merge - 27 Jun 2021
avatar wilsonge wilsonge - change - 27 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-27 22:41:38
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 27 Jun 2021

Thanks!

avatar brianteeman
brianteeman - comment - 28 Jun 2021

thanks

Add a Comment

Login with GitHub to post a comment