[#34608] - Fix metismenu caret wrapping
- Fixed in Code Base
- 27 Jun 2021
- Medium
- Build: 4.0-dev
- # 34608
- Diff
- RickR2H:mm-menu-fix
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Summary of Changes
When an menu item has a longer title then the other items in the Metismenu dropdown, the caret will wrap to the next line. This PR fixes this issue.
Testing Instructions
install the Blog Sample Data.
Open the menu "Main Menu Blog".
Open the menu item "Articles" and rename it to "Articles Longer Title To Test".
The caret now wraps underneath the menu item title.
Please test all drop down possibilities in the menu. This is easily done by batch copying a menu item with multiple sub-items.
In the last commits I added fixes for long titles. So please also add some items with longer titles (6 or 7 words)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Have you verified how your change looks when the metismenu is at other module positions, e.g. sidebar right or top-main? I see you added a span in the markup but styling in scss you have chsnhed only for the header section.
I'll check! Thanks!
@richard67 Checked all positions and made some fixes. Could you take a look?
I don’t think it’s right to have styling for .container-header in the _metismenu.scss file. But I’m not a CSS expert. Maybe @drmenzelit can have a look.
@richard67 I agree. I've moved the styling for the .container-header to the _header.scss file.
@richard67 I get a CI failing build. Can you tell me if this is something I have to fix?
No - thats a known issue unrelated to your PR that has being going on for far too long
It’s a problem which currently all PRs have and there is nothing you can do about it. People are already working on it.
Thanks! I'll ignore the error.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
I have tested this item
My menu is now broken
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
@drmenzelit please rebuild the SCSS by running in the Joomla root: npm ci
Or download the fork via: https://github.com/RickR2H/joomla-cms/archive/mm-menu-fix.zip and install
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
I have tested this item
After downloading the full Joomla branch with Rick's changes, manually installing composer and NPM dependencies, it worked for me after recompiling the SCSS.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
I have tested this item
After running npm ci several times now the PR is working :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
I've restored the previous test results in the issue tracker since the commit which invalidated the count was only a code style change.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34608.
Thanks @richard67
Drone failure is not related to this PR but to a general issue with our analysis4x check in Drone. SST is still working on it.
| Title |
|
||||||
@richard67 Looks like a carrot to me!!
If it was a carrot it would be a vegan menu.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-27 10:19:03 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
Documentation Required
|
||
Thanks guys!
Have you verified how your change looks when the metismenu is at other module positions, e.g. sidebar right or top-main? I see you added a span in the markup but styling in scss you have chsnhed only for the header section.