[#34601] - [4.0] Remove tooltip from add-new-buttons
- Fixed in Code Base
- 30 Jun 2021
- Medium
- Build: 4.0-dev
- # 34601
- Diff
- chmst:category-list-add-item
User tests: Successful: Unsuccessful:
Pull Request for Issue #34594 .
Summary of Changes
There are two category lists, contact and article categories.
Users can get a link to the form where they can add a new item.
This PR removes the tooltip from the button and adds a more specific text.
Testing Instructions
Make a category list for contacts and article categories,
Login to get the permission for adding new items,
Compare the buttons before and after the PR.
Actual result BEFORE applying this Pull Request
see #34594
Expected result AFTER applying this Pull Request
Additional Information
The file create.php could be removed after this PR, at least I cannot find where it is used.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact com_content |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
Got this result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
<a href="/example.org/index.php/list-contacts?task=contact.add&return=aHR0cHM6Ly93d3cud2Fsa2MuYXQvc2FuZGtpc3RlNC9pbmRleC5waHAvbGlzdC1jb250YWN0cw==&id=0&catid=25" class="btn btn-primary">New Contact</a>
New article:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
@Bakual could you please have a look here? I would like to remove the language keys and the layout too but have no clue if there is a "legacy" reason for that.
Thanks for testing @ChristineWk .. maybe I will ask you to repeat :)
The strings can be removed for sure as they are specific to the extension and can't be used by others.
The JLayout could be used by 3rd party as it doesn't contain any extension specific code. I honestly don't know if it's used or not, It certainly isn't a very important one and could be easily replaced with one or two lines of code in the extension. So I'd say it's save to remove as well.
I know that weblinks useses the language string JNEW, as it is such a generic string. There it is not a problem as the component is reviewed for J4.
I was referring to COM_CONTACT_CREATE_CONTACT and COM_CONTENT_CREATE_CONTACT
I was referring to COM_CONTACT_CREATE_CONTACT and COM_CONTENT_CREATE_CONTACT
@brianteeman I guess you mean COM_CONTACT_CREATE_CONTACT and COM_CONTENT_CREATE_ARTICLE
| Labels |
Added:
?
|
||
| Category | Administration com_contact com_content | ⇒ | Administration com_contact com_content Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
Checked language strings:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
previous screenshot corrected:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34601.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-30 07:47:06 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
If the layout is unused can someone do an additional PR to deprecate it for 5.0 please
This PR removes the only use of a layout and two strings