[#34597] - [4.0] Change the select all toggle to a checkbox in media manager
- Fixed in Code Base
- 2 Jul 2021
- Medium
- Build: 4.0-dev
- # 34597
- Diff
- Digital-Peak:j4/media/check
User tests: Successful: Unsuccessful:
Pull Request for Issue #34204.
Summary of Changes
Replace the link to toggle all selection with a checkbox.
Testing Instructions
- Go to /administrator/index.php?option=com_media
- Click the toggle all selection link
Actual result BEFORE applying this Pull Request
All items are selected.
Expected result AFTER applying this Pull Request
All items are selected.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Repository |
| Labels |
Added:
NPM Resource Changed
?
|
||
Still not right
Ok, figured it out, the problem is that preventDefault should not be called, otherwise the checkbox is not selected. If somebody else will come across this one, it is needed to stop propagation because of event listener here https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_media/resources/scripts/components/browser/browser.vue#L173. So we are not unselecting all of the items first which would result in an extra call. A side effect would be that the checkbox can't be watched and unselected when a single item gets selected.
@brianteeman check again.
I have tested this item
woohoo
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34597.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34597.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34597.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @laoneo Please fix code style errors reported here: https://ci.joomla.org/joomla/joomla-cms/45335/1/21
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34597.
| Labels |
Added:
?
|
||
@richard67 cs fixed...
| Status | Pending | ⇒ | Ready to Commit |
I've restored the previous test results in the issue tracker since the commit which invalidated the test count was just code style.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34597.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-02 13:14:03 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
Removed: ? |
||
Thank you!
Almost perfect.
Checking the box correctly selects all but when you do anything else afterwards which changes the selection the box remains checked. Which means you have to click it about three times to select all again