[#34593] - [4.0] Sticky table header
- Closed
- 22 Jan 2022
- Medium
- Build: 4.0-dev
- # 34593
- Diff
- brianteeman:tue1
User tests: Successful: Unsuccessful:
This pr leverages a fixed bug in chrome 91 to allow the setting of position sticky to table headers.
To test rebuild the css npm run build:css
On any admin view containing a table eg list of article or list of menu items make sure that you have more rows in the table than the height of your browser.
Scroll down and the toolbar is sticky but the table headers disappear
Apply this PR
Scroll down and the toolbar is sticky and the table headers are sticky
If your browser does not support this then its just ignored and no change will be observed.
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I can fix that easily enough - if this PR is desired.
On mobile.
I am for this PR.
easy fixes. thanks for testing them. I will fix both tonight
| Labels |
Added:
NPM Resource Changed
?
|
||
Please fix conflict.
Please fix the vertical ellipse in the header under Categories.
@brianteeman Could you solve the conflict here in _table.scss? I think it comes from PR #34621 , so you should change var(--atum-bg-dark-50) to var(--template-bg-dark-50).
| Labels |
Added:
Conflicting Files
|
||
conflicts resolved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34593.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34593.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34593.
I like this idea a lot, just two minor thoughts:
- I'm not sure about the box-shadow TBH, it gives a 3d effect which does not fit to 100% to the flat table (I see, that there is a "separator" needed when scrolling)
- Is it possible to prevent that it's glued to the navbar?
@brianteeman could you please check my two issues points? If there is an improvement possible (especially with the last one) I would be happy, otherwise I will merge.
I'm not sure about the box-shadow TBH, it gives a 3d effect which does not fit to 100% to the flat table (I see, that there is a "separator" needed when scrolling)
The box shadow you refer to exists before this pr
Is it possible to prevent that it's glued to the navbar?
Not sure I understand you
I'm not sure about the box-shadow TBH, it gives a 3d effect which does not fit to 100% to the flat table (I see, that there is a "separator" needed when scrolling)
The box shadow you refer to exists before this pr
Before:
With PR:
This is the shadow I mean: https://github.com/joomla/joomla-cms/pull/34593/files#diff-d59aacea1f8715ae7515cde80c9ae4919762203616cd7f05d95aa4653d0b41fbR87
Is it possible to prevent that it's glued to the navbar?
Not sure I understand you
Here they're not glued together, have a bit of spacing
@brianteeman Could you check @bembelimen 's previous comment? Thanks in advance.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as effectively there's a undesired change in the th styling found by @bembelimen (should be a quick fix I imagine)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34593.
| Status | Pending | ⇒ | Needs Review |
Setting status "Needs Review" in the issue tracker.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34593.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-22 22:51:22 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
?
Removed: Conflicting Files ? |
||
Go to Home Dashboard.