? ? Composer Dependency Changed Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
21 Jun 2021

Summary of Changes

Fix for PHP 8

Deprecated: usort(): Returning bool from comparison function is deprecated, 
return an integer less than, equal to, or greater than zero in

Testing Instructions

Code review.

Or:

Apply patch. Make sure your PHP shows deprecated messages.
Enable debug.
Navigate around site.
In debug bar click a "folder" icon to open debug history.

Actual result BEFORE applying this Pull Request

The history popup is empty

Expected result AFTER applying this Pull Request

The history popup not empty, and you can select previous debug.

Documentation Changes Required

none

avatar Fedik Fedik - open - 21 Jun 2021
avatar Fedik Fedik - change - 21 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2021
Category Front End Plugins
avatar richard67
richard67 - comment - 21 Jun 2021

@Fedik I guess it needs PHP 8 to get the deprecated message, right? Your testing instructions don't mention that.

avatar richard67 richard67 - test_item - 21 Jun 2021 - Tested successfully
avatar richard67
richard67 - comment - 21 Jun 2021

I have tested this item successfully on d12fe3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34581.

avatar Fedik
Fedik - comment - 21 Jun 2021

yes, right I got it on PHP 8

avatar Fedik Fedik - change - 21 Jun 2021
The description was changed
avatar Fedik Fedik - edited - 21 Jun 2021
avatar alikon alikon - test_item - 21 Jun 2021 - Tested successfully
avatar alikon
alikon - comment - 21 Jun 2021

I have tested this item successfully on d12fe3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34581.

avatar alikon alikon - change - 21 Jun 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34581.

avatar Quy Quy - change - 21 Jun 2021
Labels Added: ?
avatar wilsonge wilsonge - change - 27 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-27 10:06:16
Closed_By wilsonge
Labels Added: ? Composer Dependency Changed
avatar wilsonge wilsonge - close - 27 Jun 2021
avatar wilsonge wilsonge - merge - 27 Jun 2021
avatar wilsonge
wilsonge - comment - 27 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment