[#34576] - [4.0] contact icons
- Fixed in Code Base
- 27 Jun 2021
- Medium
- Build: 4.0-dev
- # 34576
- Diff
- brianteeman:contact_icons
User tests: Successful: Unsuccessful:
The entire point of the _icomoon.scss file is to map fontawesome icons to the icons used in joomla 3 from icomoon
Somehow the wrong icons were used for icon-address and icon-vcard
You can see the original icomoon icons here https://docs.joomla.org/J3.x:Joomla_Standard_Icomoon_Fonts
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
Testing the single contact I noticed that the address icon is wrong.
Change in: components\com_contact\tmpl\contact\default_address.php on line: 25 change "icon-address" to "icon-address-book"
With this PR you dont need to make that change - thats the whole point of it ;)
With this PR you dont need to make that change - thats the whole point of it ;)
Okay! I see what you mean, I think there is something wrong with my SCSS compile. I rebuild the SCSS but the old icon remains. I will do an other clean test just to get it to work on my end.
Hey Brian,
I did a clean install to test the icons. I applied the patch and compiled the SCSS again. Still I get the wrong icon. Am I missing something?
Sorry you have to rebuild everything with npm ci to get the correct icon
I have tested this item
After rebuilding I got the correct result!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34576.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34576.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-27 10:22:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Documentation Required
|
||
Thanks!
thanks
I have tested this item✅ successfully on 06b2784
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34576.