Feeling Lucky
Conflicting Files
PR-4.3-dev
[#34570] - Categories and Category model cleanup
- Closed
- 29 Dec 2022
- Medium
- Build: 4.0-dev
- # 34570
- Diff
- joomdonation:categories_category_model_cleanup
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Some clean up to Categories and Category model of com_contnet:
- Code simplify for getting active menu item
- Remove un-used class properties for Category Model
- Added missing class properties for Category Model
- Correct return data type and docblock for some methods
If this is accepted, we can do similar changes for other components.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 19 Aug 2021
can we kick drone again to see what its complaining about?
| Labels |
Added:
?
Removed: ? |
||
chmst
- comment
- 31 Jan 2022
@joomdonation could you please resolve the conflict?
HLeithner
- comment
- 27 Jun 2022
This pull request has automatically rebased to 4.2-dev.
rdeutz
- | Title |
|
||||||
| Labels |
Added:
Conflicting Files
?
Removed: ? |
||
| Labels |
Added:
PR-4.3-dev
|
||
| Labels |
Removed:
?
|
||
drmenzelit
- comment
- 22 Oct 2022
@joomdonation can you please check your PRs, rebase to 4.3 and resolve conflicts? Thanks
joomdonation
- comment
- 29 Dec 2022
Closing because the PR looks much more complicated than how it was due to conflict.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-29 15:05:42 |
| Closed_By | ⇒ | joomdonation |
I have tested this item✅ successfully on 76af266
my type of PR - love it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34570.