? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
18 Jun 2021

Dear colleagues. How many web designers create websites using the Cassiopeia template, redefining its blocks, creating a completely new design?
I do the same thing. The Cassiopeia template has accessibility, normalization, styles, and a framework. This template is ideal for starting even if you need to create a website with a completely different design.
But Cassiopeia is not adapted for use on a large scale with such capabilities.
Cassiopeia is used only with the design that is already laid down. This is bad. It can not be used as NORMALIZE.CSS is used.
We need to add this to the template:
//134 line
<jdoc:include type="modules" name="top" style="none" class="grid-child" />
//180 line
<jdoc:include type="modules" name="bottom" style="none" class="grid-child" />
The important thing is that you need to add these positions without the <DIV> container.
Using classes in a position
class="grid-child"
we specify that the position will have the default grid width that all blocks on the site have.
Class processing should be added to
//25 line \templates\cassiopeia\html\layouts\chromes\noCard.php
//25 line \templates\cassiopeia\html\layouts\chromes\card.php

$moduleAttribs['class'] = $module->position . ' no-card ' . ($params->get('moduleclass_sfx') ?
			(htmlspecialchars($params->get('moduleclass_sfx'), ENT_QUOTES, 'UTF-8')) : $attribs['class']);

Add the GRID-ARIA grid position to the styles.
.
Dear colleagues, thanks to the change. You can create modules on the site that are the width of the entire site, this can be a map of the route map. It can be a carousel of products. Agree that the driving directions and carousel are convenient when they are the entire width of the site.
Let's make more features for Cassiopeia!
By default, this position has only the width of the content.
This is also convenient when placing just ordinary modules.
If desired, we can place the gallery in the entire width of the site between the blocks.
90% of sites have a gallery in the site header with a width of 100% without affecting the main menu.
For example, the Xiaomi website.
https://www.mi.com/global/
https://www.solus.com/
to make a wide module, you need to add a class suffix full-width in the module settings of the admin panel.

avatar korenevskiy korenevskiy - open - 18 Jun 2021
avatar korenevskiy korenevskiy - change - 18 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2021
Category Language & Strings Layout Libraries Front End Templates (site) NPM Change
avatar richard67
richard67 - comment - 18 Jun 2021

@korenevskiy Shall this be a replacement for our other PR #34477 ? If so, then please close the other one.

avatar korenevskiy
korenevskiy - comment - 18 Jun 2021

@richard67

@korenevskiy Shall this be a replacement for our other PR #34477 ? If so, then please close the other one.

They are the same.
But I don't understand. Why is there a test error in another PR 34477?
Please tell me what is the problem there?
I created the same PR to check if it will pass the test.
Help me understand the error in the tests, I will close this PR

avatar richard67
richard67 - comment - 18 Jun 2021

@korenevskiy If you check the log of the Drone checks of the other PR you will see it is a credentials problem at the analysis4x Test. That is unrelated to your PR and can happen sometimes. I have already notified people to fix that.

Opening multiple PRs for the same thing without any hint about that in the PR‘s description with a reference to the other PR causes unnecessary attention of maintainers and so wastes our time.

avatar korenevskiy
korenevskiy - comment - 19 Jun 2021

@korenevskiy If you check the log of the Drone checks of the other PR you will see it is a credentials problem at the analysis4x Test. That is unrelated to your PR and can happen sometimes. I have already notified people to fix that.

Opening multiple PRs for the same thing without any hint about that in the PR‘s description with a reference to the other PR causes unnecessary attention of maintainers and so wastes our time.

I understand that it is wasting your time, but I just wanted to solve this problem myself. I didn't know exactly if this problem was related to me. And so I decided to test and close the PR. But you found the PR very quickly..
Thank you for your help.
I had the best intentions.
I'm closing the PR.

avatar korenevskiy korenevskiy - change - 19 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-19 00:26:16
Closed_By korenevskiy
Labels Added: ? NPM Resource Changed ?
avatar korenevskiy korenevskiy - close - 19 Jun 2021

Add a Comment

Login with GitHub to post a comment