?
avatar piotr-cz
piotr-cz
18 Jun 2021

Steps to reproduce the issue

  1. Install extension with stability lower than Stable (ie. Beta, Release Candidate) and updates in manifest with stability lower than Stable

  2. Set up Minimum Extension Stability to: Development
    Administrator > Global Configuration > Installer

  3. Start Joomla update from 4.0.0-rc.1 to 4.0.0-rc.2

Expected result

Extension Pre-Update Check should not show extension in Update Information Unavailable section

Actual result

Extension Pre-Update Check shows extension in Update Information Unavailable section.

System information (as much as possible)

Joomla 4.0.0-rc.1

Additional comments

Extension Pre-Update Check doesn't use options set up in the Installer component to determine compatibility with Joomla 4:

The checkCompatibility method

should use same logic as getUpdateInformation method

$update->loadFromXml($updateObject->detailsurl, $minimumStability);

when accessing Joomla\CMS\Updater\Update::loadFromXml:

public function loadFromXml($url, $minimumStability = Updater::STABILITY_STABLE)

avatar piotr-cz piotr-cz - open - 18 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Jun 2021
avatar zero-24
zero-24 - comment - 18 Jun 2021

Can you confirm that issue with 3.10 too? So it would be an issue to be patched in 3.10 than.

avatar piotr-cz
piotr-cz - comment - 18 Jun 2021

I can only confirm by looking at the Joomla 3.10 codebase - yes the issue should be present as well

$update->loadFromXML($updateFileUrl);

avatar zero-24
zero-24 - comment - 18 Jun 2021

Ok thanks, then this should be fixed in 3.10 and than merged up to 4.0

avatar zero-24 zero-24 - change - 18 Jun 2021
Title
[4.0] Pre-Update Check - Doesn't repect Minimum Extension Stability
[3.10] [4.0] Pre-Update Check - Doesn't repect Minimum Extension Stability
avatar zero-24 zero-24 - edited - 18 Jun 2021
avatar zero-24 zero-24 - close - 13 Jul 2021
avatar zero-24
zero-24 - comment - 13 Jul 2021

A PR for Joomla 3.10 has been done here: #34772 Please test it @piotr-cz

avatar zero-24 zero-24 - change - 13 Jul 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-07-13 18:38:17
Closed_By zero-24

Add a Comment

Login with GitHub to post a comment