User tests: Successful: Unsuccessful:
In list view, the caption text is wrong for the Ordering column and ascending/descending are not translated.
Go to Global Configuration > System
Enable Debug Language.
In https://github.com/Quy/joomla-cms/blob/30c1d8ce688c9e84e6f996bb1877a9fdec23fc94/administrator/components/com_content/tmpl/articles/default.php#L110
Change <caption class="visually-hidden">
to <caption class="caption-top">
.
Go to Content > Articles
In Sort Table By dropdown, select Ordering ascending/descending.
In Sort Table By dropdown, select Status ascending/descending.
Apply PR.
See captions for the above.
**Table of Articles**, **Sorted by:** **ID**,
**Table of Articles**, **Sorted by:** **ID**,
**Table of Articles**, **Sorted by:** **Status** - ascending,
**Table of Articles**, **Sorted by:** **Status** - descending,
**Table of Articles**, **Sorted by:** **Ordering** **Ascending**,
**Table of Articles**, **Sorted by:** **Ordering** **Descending**,
**Table of Articles**, **Sorted by:** **Status** - **Ascending**,
**Table of Articles**, **Sorted by:** **Status** - **Descending**,
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Labels |
Added:
?
|
Hyphen added. Thanks.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
I have not tested this item.
()
is removed from ($sort)
which should not affect your test. sort
has to be outside of the ternary operator.
you changed the code from what was tested - hence I removed my successful test
Status | Ready to Commit | ⇒ | Pending |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Does this work for RTL languages? Probably we need a sprintf solution here?
Being RTL is not relevant here
However you are correct that the order of the two strings may be different in different languages
Being RTL is not relevant here
However you are correct that the order of the two strings may be different in different languages
Yes that was what I meant, thx.
Status | Ready to Commit | ⇒ | Pending |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-30 20:59:14 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Could you keep the " - " please - it is useful for screen readers as it acts as a pause