? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
15 Jun 2021

Summary of Changes

In list view, the caption text is wrong for the Ordering column and ascending/descending are not translated.

Testing Instructions

Go to Global Configuration > System
Enable Debug Language.

In https://github.com/Quy/joomla-cms/blob/30c1d8ce688c9e84e6f996bb1877a9fdec23fc94/administrator/components/com_content/tmpl/articles/default.php#L110
Change <caption class="visually-hidden"> to <caption class="caption-top">.

Go to Content > Articles
In Sort Table By dropdown, select Ordering ascending/descending.
In Sort Table By dropdown, select Status ascending/descending.

Apply PR.

See captions for the above.

Actual result BEFORE applying this Pull Request

**Table of Articles**, **Sorted by:** **ID**,
**Table of Articles**, **Sorted by:** **ID**,

**Table of Articles**, **Sorted by:** **Status** - ascending,
**Table of Articles**, **Sorted by:** **Status** - descending, 

Expected result AFTER applying this Pull Request

**Table of Articles**, **Sorted by:** **Ordering** **Ascending**, 
**Table of Articles**, **Sorted by:** **Ordering** **Descending**, 

**Table of Articles**, **Sorted by:** **Status** - **Ascending**, 
**Table of Articles**, **Sorted by:** **Status** - **Descending**, 

avatar Quy Quy - open - 15 Jun 2021
avatar Quy Quy - change - 15 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2021
Category Layout
avatar Quy Quy - change - 15 Jun 2021
The description was changed
avatar Quy Quy - edited - 15 Jun 2021
avatar Quy Quy - change - 15 Jun 2021
The description was changed
avatar Quy Quy - edited - 15 Jun 2021
avatar Quy Quy - change - 15 Jun 2021
The description was changed
avatar Quy Quy - edited - 15 Jun 2021
avatar brianteeman
brianteeman - comment - 15 Jun 2021

Could you keep the " - " please - it is useful for screen readers as it acts as a pause

avatar Quy Quy - change - 15 Jun 2021
Labels Added: ?
avatar Quy Quy - change - 15 Jun 2021
The description was changed
avatar Quy Quy - edited - 15 Jun 2021
avatar Quy
Quy - comment - 15 Jun 2021

Hyphen added. Thanks.

avatar brianteeman brianteeman - test_item - 15 Jun 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 15 Jun 2021

I have tested this item successfully on 812c999


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar sandramay0905 sandramay0905 - test_item - 16 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 16 Jun 2021

I have tested this item successfully on 812c999


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar Quy Quy - alter_testresult - 16 Jun 2021 - brianteeman: Tested successfully
avatar Quy Quy - alter_testresult - 16 Jun 2021 - sandramay0905: Tested successfully
avatar Quy Quy - change - 16 Jun 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar brianteeman
brianteeman - comment - 16 Jun 2021

the last change you made looks wrong

image

avatar brianteeman brianteeman - test_item - 16 Jun 2021 - Not tested
avatar brianteeman
brianteeman - comment - 16 Jun 2021

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar Quy
Quy - comment - 16 Jun 2021

() is removed from ($sort) which should not affect your test. sort has to be outside of the ternary operator.

avatar brianteeman
brianteeman - comment - 16 Jun 2021

you changed the code from what was tested - hence I removed my successful test

avatar Quy Quy - change - 16 Jun 2021
Status Ready to Commit Pending
avatar chmst chmst - test_item - 18 Jun 2021 - Tested successfully
avatar chmst
chmst - comment - 18 Jun 2021

I have tested this item successfully on 362c71c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar chmst chmst - change - 18 Jun 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 18 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34524.

avatar bembelimen
bembelimen - comment - 21 Jun 2021

Does this work for RTL languages? Probably we need a sprintf solution here?

avatar brianteeman
brianteeman - comment - 21 Jun 2021

Being RTL is not relevant here

However you are correct that the order of the two strings may be different in different languages

avatar bembelimen
bembelimen - comment - 21 Jun 2021

Being RTL is not relevant here

However you are correct that the order of the two strings may be different in different languages

Yes that was what I meant, thx.

avatar chmst chmst - change - 21 Jun 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 22 Jun 2021

@Quy Could you check the previous 3 comments?

avatar Quy Quy - change - 30 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-30 20:59:14
Closed_By Quy
Labels Added: ?
avatar Quy
Quy - comment - 30 Jun 2021

Closing in favor of #34672.

avatar Quy Quy - close - 30 Jun 2021

Add a Comment

Login with GitHub to post a comment