User tests: Successful: Unsuccessful:
Pull Request for Issue # .
With commit 6274e5f from merging up stuff from 3.10-dev, file "administrator/components/com_media/helpers/media.php" has been added to 4.0-dev.
This was not a mistake, and as long as that files is not namespaced and renamed and moved to the "administrator/components/com_media/src/Helper" folder, it is used in J4 here: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php#L250
The file was not present before and so the file and its parent folders would be deleted when updating from 3.10 to the next J4 RC 2.
This pull request here fixes that by removing the file and its parent folder from the files and folder deletion in script.php.
Code review.
File "administrator/components/com_media/helpers/media.php" and folder "administrator/components/com_media/helpers" will be deleted when updating from 3.10.
File "administrator/components/com_media/helpers/media.php" and folder "administrator/components/com_media/helpers" will not be deleted when updating from 3.10.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-14 12:50:44 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
?
|
Thanks!