? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
14 Jun 2021

Pull Request for Issue # .

Summary of Changes

With commit 6274e5f from merging up stuff from 3.10-dev, file "administrator/components/com_media/helpers/media.php" has been added to 4.0-dev.

This was not a mistake, and as long as that files is not namespaced and renamed and moved to the "administrator/components/com_media/src/Helper" folder, it is used in J4 here: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php#L250

The file was not present before and so the file and its parent folders would be deleted when updating from 3.10 to the next J4 RC 2.

This pull request here fixes that by removing the file and its parent folder from the files and folder deletion in script.php.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

File "administrator/components/com_media/helpers/media.php" and folder "administrator/components/com_media/helpers" will be deleted when updating from 3.10.

Expected result AFTER applying this Pull Request

File "administrator/components/com_media/helpers/media.php" and folder "administrator/components/com_media/helpers" will not be deleted when updating from 3.10.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 14 Jun 2021
avatar richard67 richard67 - change - 14 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2021
Category Administration com_admin
avatar richard67 richard67 - change - 14 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 14 Jun 2021
avatar wilsonge wilsonge - close - 14 Jun 2021
avatar wilsonge wilsonge - merge - 14 Jun 2021
avatar wilsonge wilsonge - change - 14 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-14 12:50:44
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 14 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment