[#34503] - [4.0] Smart Search: Fix inserting tokens to DB
- Fixed in Code Base
- 14 Jun 2021
- Medium
- Build: 4.0-dev
- # 34503
- Diff
- Hackwar:patch-9
User tests: Successful: Unsuccessful:
This is the Pull Request for the J3 Issue #34242 in 4.0.
Summary of Changes
When indexing, due to a logic error, the words of a text were only stored to the database in chunks of 128 at a time. If a chunk had less than 128 words, it wasn't saved to the database. This change fixes that. However, in 4.0, the bug had been fixed in a different way. In order to keep the code in sync, the better and shorter solution of 3.9 is used here.
Testing Instructions
Have Smart Search be set up. Write a short article (less than 128 words) with a unique word and save it. Then go to the frontend and search for that unique word. You don't get a result.
Apply the patch, reindex the content and search for it again. Now you get the article as result.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
However, in 4.0, the bug had been fixed (...) You don't get a result.
I created a article in english on a multilanguage site having ten words including unique word "sousousouxxx" and get a result with and without this pull request.
@Hackwar I'm not sure if this is a successfully test.
As I wrote, this worked in 4.0 already, but this code is the better solution. So, yes, this would be a successfull test.
I have tested this item
Thanks for information @Hackwar I was not sure cause of "You don't get a result."
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34503.
I have tested this item
Search result show the unique word from the short article.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34503.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34503.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-14 20:16:14 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
I created a article in english on a multilanguage site having ten words including unique word "sousousouxxx" and get a result with and without this pull request.
@Hackwar I'm not sure if this is a successfully test.