? ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
13 Jun 2021

Summary of Changes

I am engaged in translation. Found a lot of unused constants in joomla.ini.

I delete them in the PR, then copy / paste to the API directory.

And added a constant for the AUTHOR meta tag, as using a generic constant is not a good idea. For example, in Russian, we translate all meta-tags "Метатег Robots", "Метатег Keywords" ... And suddenly, among the meta-data, there is just the line AUTHOR.

avatar Kostelano Kostelano - change - 13 Jun 2021
Status New Pending
avatar Kostelano Kostelano - open - 13 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2021
Category Administration com_categories com_content com_tags Language & Strings Front End
avatar richard67
richard67 - comment - 13 Jun 2021

Are you sure that these strings are all not used? In some (rare) cases language constants are combined in code from parts, so you won’t find the complete language constant when searching for it.

avatar brianteeman
brianteeman - comment - 13 Jun 2021

also please note I have personally never removed strings from joomla.ini as thats a generic language file that is used by extensions

avatar Kostelano
Kostelano - comment - 13 Jun 2021

I know that part of a string is sometimes used, so I tested strings in a similar way. Of course, I would be glad if someone re-checks, but I think that everything is in order here.

As for other extensions, it is certainly impossible to guess here, but I do not think that many extensions use the lines of the main file. Besides, it is not a good idea to "reserve" a lot of unused lines of Joomla itself for some third-party extension, since the number of such lines will grow forever.

Here in the PR there are lines that were probably used back in Joomla 1.0 :).

avatar brianteeman
brianteeman - comment - 13 Jun 2021

Here in the PR there are lines that were probably used back in Joomla 1.0 :).

Probably - even more reason that they are used elsewhere.

As for other extensions, it is certainly impossible to guess here, but I do not think that many extensions use the lines of the main file.

And that's a guess ;)

It took me 15 years to delete a string from specific language files.

avatar Kostelano Kostelano - change - 14 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-14 07:39:22
Closed_By Kostelano
Labels Added: ? ?
avatar Kostelano Kostelano - close - 14 Jun 2021

Add a Comment

Login with GitHub to post a comment