?

Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
12 Jun 2021

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the lists of files and folders to be deleted on update in script.php to recent changes.

Some of the files should have been added in the previous 4.0 RC 1, so this PR adds them to the section for update from Beta 7 to RC 1.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

  1. After an update from 3.10 or from 4.0 Beta 7 or RC 1, the libraries/vendor/paragonie/random_compat folder with subfolders and files are still present. Which subfolders and files depends on the version from which you have updated. As random_compat has been removed in J4 from dependencies, the libraries/vendor/paragonie/random_compat should be removed with the update.
  2. After an update from 4.0 RC 1 or previous 4.0 Beta versions, following files are still present despite of their removal in sources and packages:
  • administrator/templates/atum/scss/pages/_com_admin.scss (removed with #34406 )
  • administrator/templates/atum/scss/pages/_com_finder.scss (removed with #34403 )
  • administrator/templates/atum/scss/pages/_com_joomlaupdate.scss (removed with #34407 )
  • libraries/src/Error/JsonApi/InstallLanguageExceptionHandler.php (removed with fe93f16 )
  • libraries/src/MVC/Controller/Exception/InstallLanguage.php (removed with fe93f16 )

Expected result AFTER applying this Pull Request

  1. The libraries/vendor/paragonie/random_compat folder is completely deleted after an update from 3.10 or from 4.0 Beta 7 or RC 1.
  2. The files mentioned with point 2 of the previous section "Actual result BEFORE applying this Pull Request" are deleted after an update from 4.0 RC 1 or previous 4.0 Beta versions.

Documentation Changes Required

None.

Other information

Any discussions about issue #34298 are off topic for this PR.

avatar richard67 richard67 - open - 12 Jun 2021
avatar richard67 richard67 - change - 12 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2021
Category Administration com_admin
avatar richard67 richard67 - change - 12 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 12 Jun 2021
avatar richard67 richard67 - change - 12 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 12 Jun 2021
avatar richard67 richard67 - change - 12 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 12 Jun 2021
avatar richard67 richard67 - change - 12 Jun 2021
The description was changed
avatar richard67 richard67 - edited - 12 Jun 2021
avatar richard67 richard67 - change - 12 Jun 2021
Title
[4.0] [WiP] Update files and folders deletion on updates to 4.0 RC 2
[4.0] Update files and folders deletion on updates to 4.0 RC 2
avatar richard67 richard67 - edited - 12 Jun 2021
avatar wilsonge wilsonge - change - 12 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-12 13:47:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 Jun 2021
avatar wilsonge wilsonge - merge - 12 Jun 2021
avatar wilsonge
wilsonge - comment - 12 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment