?
avatar ceford
ceford
11 Jun 2021

Steps to reproduce the issue

Use https://validator.w3.org/nu/#textarea to validate a page containing uitabs (article edit form).
It flags errors:
Error: Attribute name not allowed on element section at this point.
<section id="dateSelect" name="Dates">
One for every tab.

If I change libraries/src/HTML/Helpers/UiTab.php so that line 92 has data-name rather than name AND
I change media/vendor/joomla-custom-elements/js/joomla-tab.js so that line 246 has data-name rather than name
then the tabs still work and do not cause validation errors.

Is this something to worry about? Should it be fixed?

Expected result

Actual result

System information (as much as possible)

Additional comments

avatar ceford ceford - open - 11 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Jun 2021
avatar brianteeman
brianteeman - comment - 11 Jun 2021

name is not a valid element for a section

data-* is ignored by all checkers so will pass any test and its usually used if you need to pass something to javascript

avatar dgrammatiko
dgrammatiko - comment - 11 Jun 2021

<section id="dateSelect" name="Dates">

This shouldn't be a section element but a custom element and then the name attribute is totally valid. That said there are other more serious problems with the joomla-tabs custom elements...

avatar ceford
ceford - comment - 12 Jun 2021

I decided to roll my own tabs so I am not pursuing this. However, I am leaving it open because I don't think Joomla should release 4.0 knowing some pages will fail validation.

avatar brianteeman
brianteeman - comment - 12 Jun 2021

How disappointing

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2021

How disappointing

What's actually disappointing is that you personally cancelled all my attempts to fix the custom elements. Count this comment also as another one

avatar brianteeman
brianteeman - comment - 12 Jun 2021

me?

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2021
avatar Quy
Quy - comment - 17 Jul 2021

Please test PR #34813

avatar Quy Quy - change - 17 Jul 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-07-17 20:49:16
Closed_By Quy
avatar Quy Quy - close - 17 Jul 2021

Add a Comment

Login with GitHub to post a comment