[#34483] - Fix W3C Warning role="navigation" is unnecessary for element nav
- Fixed in Code Base
- 10 Jun 2021
- Medium
- Build: 4.0-dev
- # 34483
- Diff
- RickR2H:fix-nav-role
User tests: Successful: Unsuccessful:
Summary of Changes
The breadcrumbs have the ARIA role="navigation", but this is unnecessary for nav elements. Also added a classes for easy styling.
Testing Instructions
Look at the code of the breadcrumbs and the pagination and see if the the role element is there. Apply the patch and check if the role element is gone and the class added.
Actual result BEFORE applying this Pull Request
role="navigation" present
Expected result AFTER applying this Pull Request
role="navigation" is removed and nav has a class
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Layout Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34483.
@RickR2H Are you testing your own PR here?
At least @RichardR2H seems to have the same web site as you.
@richard67 Of course not! Both are co-workers and I asked them to test. Both are genuine individuals!
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34483.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-10 08:56:17 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on e76e277
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34483.