[#34462] - [4.0] Cleanup Blog Sample Data Plugin
- Fixed in Code Base
- 9 Jun 2021
- Medium
- Build: 4.0-dev
- # 34462
- Diff
- joomdonation:clean_up_blog_sample_data_plugin
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes some cleanup to Blog Sample Data plugin:
- Correct return data type of some methods in docblock
- Unify return data type of some method to array. In some methods, we return both
arrayandstdClass, it works because at the end, the return data will be json encoded, but we should choose to use one type only. - Replace deprecated method class:
Factory::getLanguage()with$this->app->getLanguage()Factory::getUser()with$this->app->getIdentity()- Replace $app = Factory::getApplication(); with injected $this->app
Testing Instructions
- Code review
- Or install latest Joomla 4.0-dev, then install Blog Sample Data and make sure sample data is still being installed properly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have not tested :) but I will say be careful replacing Factory::getLanguage() with $this->app->getLanguage() at the moment, in 100% of the attempts I have made to replace these they then dont work. It seems it is not ready to be used through the app just yet and you dont always get the results intended.
@PhilETaylor Real test worked well for me. Also, I tried to write some code to test the behavior for some methods called on this plugin:
$this->app->getLanguage()->load
$this->app->getLanguage()->getTag()
And it worked OK. So I guess it's fine for the change in this plugin
If it works here then great, just keep in mind what I said for next time :)
If it works here then great, just keep in mind what I said for next time :)
I can only confirm it works for the changes in this PR :). For other contexts , I could not confirm :D.
/me bookmarks this thread for "next time" mwah mwah mwah
I have tested this item
Applied PR and Blog sample data populated properly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34462.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34462.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-09 06:43:47 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on a51b778
Test using welsh language.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34462.