Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34460] - [4.0] Multilingual sample data cleanup

? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
8 Jun 2021

Pull Request for Issue # .

Summary of Changes

This PR makes some cleanup to Multilingual Sample Data plugin:

  1. Remove un-used class property
  2. Correct return data type of some methods in docblock
  3. Unify return data type of some method to array. In some methods, we return both array and stdClass, it works because at the end, the return data will be json encoded, but we should choose to use one type only.
  4. Replace deprecated method class:
  • Factory::getLanguage() with $this->app->getLanguage()
  • Factory::getUser() with $this->app->getIdentity()
  1. Fixes potential fatal error

We have code $lang = Factory::getLanguage()->getTag();, then $lang->load and it will cause fatal error (because the $lang is a string, not object). This PR fixes this error, too

Testing Instructions

  1. Code review
  2. Or install latest Joomla 4.0-dev, then install Multilingual Sample Data and make sure sample data is still being installed properly.
avatar joomdonation joomdonation - open - 8 Jun 2021
avatar joomdonation joomdonation - change - 8 Jun 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2021
Category ⇒ Front End Plugins
da9b0b2 8 Jun 2021 avatar joomdonation CS
avatar joomdonation joomdonation - change - 8 Jun 2021
Labels Added: ?
avatar infograf768
infograf768 - comment - 8 Jun 2021

Works fine.

avatar sandramay0905 sandramay0905 - test_item - 8 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 8 Jun 2021

I have tested this item ✅ successfully on da9b0b2

Test using all available languages.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34460.

avatar chmst chmst - test_item - 8 Jun 2021 - Tested successfully
avatar chmst
chmst - comment - 8 Jun 2021

I have tested this item ✅ successfully on da9b0b2

Tested with dutch language and code review.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34460.

avatar richard67 richard67 - change - 8 Jun 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 8 Jun 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34460.

avatar chmst chmst - change - 9 Jun 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-06-09 06:44:39
Closed_By ⇒ chmst
Labels Added: ?
avatar chmst chmst - close - 9 Jun 2021
avatar chmst chmst - merge - 9 Jun 2021
avatar chmst
chmst - comment - 9 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment