? ? ? Pending

User tests: Successful: Unsuccessful:

avatar max123kl
max123kl
7 Jun 2021

Pull Request for Issue #34442

Summary of Changes

Arrow display modified

avatar max123kl max123kl - open - 7 Jun 2021
avatar max123kl max123kl - change - 7 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2021
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 7 Jun 2021

If this change is to made then it really should be made in the (at least) ten other places

avatar max123kl max123kl - change - 7 Jun 2021
Title
[4.0] Improving the display of an arrow in language string in "plg_system_updatenotification.*"
[WiP][4.0] Improving the display of an arrow in language string in "plg_system_updatenotification.*"
avatar max123kl max123kl - edited - 7 Jun 2021
avatar max123kl
max123kl - comment - 7 Jun 2021

I will look for the places and then add the modifications here.
Changed the title to "Work in Process" [WiP]...

avatar max123kl max123kl - change - 7 Jun 2021
Labels Added: ? ?
avatar max123kl
max123kl - comment - 7 Jun 2021

Ready to review

avatar max123kl max123kl - change - 7 Jun 2021
Title
[WiP][4.0] Improving the display of an arrow in language string in "plg_system_updatenotification.*"
[4.0] Improving the display of an arrow in language string in "plg_system_updatenotification.*"
avatar max123kl max123kl - edited - 7 Jun 2021
avatar infograf768
infograf768 - comment - 7 Jun 2021

This will force TTs with RTL languages to use ← instead of the right arrow.
I am not in favor of this change.

avatar richard67
richard67 - comment - 7 Jun 2021

I agree with @infograf768 . Like it is now without this PR, translation teams can easily see the ">" and replace it with whatever is appropriate in their language and writing system. With the changes in this PR they have to replace → e.g. with ← in case of RTL direction.

avatar max123kl
max123kl - comment - 7 Jun 2021

In the changed files, the character > (and twice ->) has been used so far.
For optical reasons, I have suggested replacing it with the right arrow. Moreover, the right arrow is used within the JDOC and JHelp pages.
The HTML code → (or → or →) is equivalent to the → right arrow (Unicode U+2192). See also

I am not familiar with RTL languages – what is used for the > character there so far?
If the character < is used there, it is very easy (if it is necessary for optical reasons at all) to take the left arrow ← (Unicode "U+2190" = HTML: &larr; or &#8592; or &#x2190;) instead.

Both arrow characters can also be entered directly via keyboard shortcuts, depending on the editor and operating system used.

avatar brianteeman
brianteeman - comment - 7 Jun 2021

Sorry that's a stupid response that once again says that we dont trust translators to do a good job. Of course they are intelligent enough to understand that they have to change a right arrow to a left arrow. And if they didn't know the html char code for the arrow (or didnt know what the code was) 5 seconds with duckduckgo would tell them.

This is a good PR and a good improvement. It is also a great accessibility improvement for anyone using a screen reader. For example the following string "content > categories" will be announced as "content greater than categories" using NVDA instead of this improved PR where it is announced as "content right arrow categories" or "content categories"

avatar brianteeman brianteeman - test_item - 7 Jun 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Jun 2021

I have tested this item successfully on 7cdcc7d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34444.

avatar tecpromotion tecpromotion - test_item - 7 Jun 2021 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 7 Jun 2021

I have tested this item successfully on 7cdcc7d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34444.

avatar richard67 richard67 - change - 7 Jun 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 Jun 2021

Am still not a fan of it, but it's not on me to decide. RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34444.

avatar rdeutz rdeutz - change - 7 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-07 21:06:15
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 7 Jun 2021
avatar rdeutz rdeutz - merge - 7 Jun 2021

Add a Comment

Login with GitHub to post a comment