? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Jun 2021

In the pre-update check list of installed components it is being translated twice which obviously will not work.

This PR removes the second pass through JText

The first instance is in the model

Either code review or install some extensions and enable language debug and go to the pre-update check and you will see either
??extension name??
or
????extension name????

After this PR it will be
extension name
or
??extension name??

avatar brianteeman brianteeman - open - 6 Jun 2021
avatar brianteeman brianteeman - change - 6 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2021
Category Administration com_joomlaupdate
avatar sandramay0905 sandramay0905 - test_item - 8 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 8 Jun 2021

I have tested this item successfully on 31713c7

Without PR With PR
Screen Shot 2021-06-08 at 08 08 23 Screen Shot 2021-06-08 at 08 10 45

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34439.
avatar Quy Quy - test_item - 8 Jun 2021 - Tested successfully
avatar Quy
Quy - comment - 8 Jun 2021

I have tested this item successfully on 31713c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34439.

avatar Quy Quy - change - 8 Jun 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 8 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34439.

avatar chmst chmst - close - 10 Jun 2021
avatar chmst chmst - merge - 10 Jun 2021
avatar chmst chmst - change - 10 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-10 18:02:40
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 10 Jun 2021

Thanks!

avatar brianteeman
brianteeman - comment - 10 Jun 2021

thank you. Makes debugging real issues easier

Add a Comment

Login with GitHub to post a comment