Feeling Lucky
?
[#3443] - sql updates
- Closed
- 26 Sep 2014
- Medium
- Build: staging
- # 3443
- Diff
- infazse:patch-4
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There are some unnecessary commit information but they are removed so PR only consists of the sql updates sorry for the inconvenience caused.
sovainfo
- comment
- 14 Apr 2014
Object to this PR because:
- The first line contains multiple update statements, there should be only one statement per line
- The first line updates don't change anything from 3.2.3, so I think they don't belong here.
- The second update is adviced to use UPDATE SET REPLACE to properly identify the change
- The format used should comply with the RDBMS. Format used in update for PostgreSQL fails regarding column naming using backticks instead of double quotes
infazse
- comment
- 16 Apr 2014
Sure will look in to it sorry for the late reply.
| Status | New | ⇒ | Confirmed |
nicksavov
- | Title |
|
||||||
| Labels |
Removed:
?
|
||||||
| Category | ⇒ | SQL |
brianteeman
- comment
- 26 Sep 2014
After 4 months I am closing this issue. Please create a new clean PR if you believe there is still an issue
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-26 14:14:31 |
146 changed files is still a bit much :-)