The icons are used in single contacts. Here for example I have added an image as icon-address

how? By using the form in the component options? That hasnt changed.

Clobal confiuration - options. sry .. will be back later

Thought so. I spent a stupid amount of time checking this

Don't blame me ;) I spent an insane amout of time to find this: it is the marker-class
https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_contact/tmpl/contact/default_address.php#L27

They're still global params aren't they?. Unless you have also found out where you can set the params for an individual contact

There is no chance for individual contacts. I think that this was long time before my "active time".
The default icons were somehow knuffy - 1990 style. And web site admins should have own icons for all their contacts (for all contacts).

There is no chance for individual contacts. I think that this was long time before my "active time".

As I said I went back 8 years without finding it

The default icons were somehow knuffy - 1990 style. And web site admins should have own icons for all their contacts (for all contacts).

Agreed and they still can. This PR doesnt change that. The only thing this pr does is to remove a bunch of fields that are defined in xml and nowhere else

Removing these fields would be a B/C break. If websites have adde here own icons. If they are removed, the lyouts can be made much easier.

Removing these fields would be a B/C break.

How? they are NOT used. The ones that are used are in the global component options

Or am I missing something

Params are used here:
https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_contact/src/View/Contact/HtmlView.php#L266

Maybe I am missing something? I never use contact without own override, so am not expert here.

Those icons are defined in the global options for the contact component aren't they?

Thats not the fields this PR is removing.

Please open joomla in your browser. You can set custom icons in the component options. There is nowhere you can set custom icons for an individual contact.

Now apply this PR. Nothing has changed. Therefore the fields in this xml are not used and can be deleted.

See if #31435 confirms this.

bingo

My bad - I mixed up the xml files. You are right.

the language strings also need to be removed or?

ah I see, it also in component config, still in use

Now we know the fields that are being removed can we get some tests please

Should the info be updated/removed as this is the only place that these settings can be configured?

Should this be fixed in J3 too?

@Quy yes, the message is wrong.

And it was always bad english. ;)

I could remove it but then there is a consistency issue with the other tabs. How about simply

These settings apply to a single contact

I don't use this feature, so cannot say where is the advantage if every contact has own icons. You could change the message and say "these settings are for all contacts and cannot be set individually" (in correct english)?

I have tested this item ✅ successfully on 5941306

I have tested this item ✅ successfully on 5941306

with Patch:

RTC

thank you