User tests: Successful: Unsuccessful:
Labels |
Added:
?
?
|
Well it's based on the google group discussion that several files aren't working in IE8 because their missing semi-colons not needed in any more up to date browsers. I'm not sure this is finished yet - I need someone with IE8 to be able to test it further.
This is targeted at staging and validate.js has been rewritten in 3.3-dev. Does that need to be updated too?
yes. That would explain why steve can't get this working in 3.3-dev sigh :P
Care to throw a quick PR together?
I can but I can't guarantee it will work on IE8 - I've had to get steve to test every time on the google group cause i don't have it
http://www.modern.ie/en-us/virtualization-tools - If you have a VM software (and you really should), Microsoft has virtual machines you can use just for this purpose. I'm downloading the Win7/IE8 machine now.
George
I was able to apply your PR3441 and PR3376 to 3.3-dev yesterday. and had no errors.
Steve
@wilsonge to save time I created this branch:
https://github.com/phproberto/joomla-cms/tree/ie8-george
which is 3.3-dev compatible and contains all the changes except the validate.js fixes. Now we should see if there are some errors there. I'll do it ASAP.
There are several :P Michael did this last night on a VPS. There's errors
in the html5 fallback and in the new validate.js on IE8 apparently. I tried
to fix what I could find on that other branch but I'm really running out of
ideas
Kind Regards,
George
On 17 April 2014 13:16, Roberto Segura notifications@github.com wrote:
@wilsongehttps://github.com/wilsonge?utm_campaign=website&utm_source=sendgrid.com&utm_medium=emailto save time I created this branch:
https://github.com/phproberto/joomla-cms/tree/ie8-georgehttps://github.com/phproberto/joomla-cms/tree/ie8-george?utm_campaign=website&utm_source=sendgrid.com&utm_medium=emailwhich is 3.3-dev compatible and contains all the changes except the
validate.js fixes. Now we should see if there are some errors there. I'll
do it ASAP.—
Reply to this email directly or view it on GitHub#3441
.
VPS ughhh VM even
I added more fixes to validate.js
( phproberto@92ea340 ) it took me a lot of time to debug that shit inside the VM :D
Closing this one as well
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-20 00:26:47 |
Looks like this has come back in 3.5.1 - html5fallback.js arorun char 1939 has a comma instead of a semi colon
@kirancheema please open a new issue. No one will see a closed issue
no worries will do
Is there a spezial way to test this? @wilsonge