? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
14 Apr 2014
avatar wilsonge wilsonge - open - 14 Apr 2014
avatar wilsonge wilsonge - change - 14 Apr 2014
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 14 Apr 2014

Is there a spezial way to test this? @wilsonge

avatar wilsonge
wilsonge - comment - 14 Apr 2014

Well it's based on the google group discussion that several files aren't working in IE8 because their missing semi-colons not needed in any more up to date browsers. I'm not sure this is finished yet - I need someone with IE8 to be able to test it further.

avatar mbabker
mbabker - comment - 16 Apr 2014

This is targeted at staging and validate.js has been rewritten in 3.3-dev. Does that need to be updated too?

avatar wilsonge
wilsonge - comment - 16 Apr 2014

yes. That would explain why steve can't get this working in 3.3-dev sigh :P

avatar mbabker
mbabker - comment - 16 Apr 2014

Care to throw a quick PR together?

avatar wilsonge
wilsonge - comment - 16 Apr 2014

I can but I can't guarantee it will work on IE8 - I've had to get steve to test every time on the google group cause i don't have it

avatar mbabker
mbabker - comment - 16 Apr 2014

http://www.modern.ie/en-us/virtualization-tools - If you have a VM software (and you really should), Microsoft has virtual machines you can use just for this purpose. I'm downloading the Win7/IE8 machine now.

avatar Stevec4
Stevec4 - comment - 17 Apr 2014

George
I was able to apply your PR3441 and PR3376 to 3.3-dev yesterday. and had no errors.
Steve

avatar phproberto
phproberto - comment - 17 Apr 2014

@wilsonge to save time I created this branch:
https://github.com/phproberto/joomla-cms/tree/ie8-george

which is 3.3-dev compatible and contains all the changes except the validate.js fixes. Now we should see if there are some errors there. I'll do it ASAP.

avatar wilsonge
wilsonge - comment - 17 Apr 2014

There are several :P Michael did this last night on a VPS. There's errors
in the html5 fallback and in the new validate.js on IE8 apparently. I tried
to fix what I could find on that other branch but I'm really running out of
ideas

Kind Regards,
George

On 17 April 2014 13:16, Roberto Segura notifications@github.com wrote:

@wilsongehttps://github.com/wilsonge?utm_campaign=website&utm_source=sendgrid.com&utm_medium=emailto save time I created this branch:
https://github.com/phproberto/joomla-cms/tree/ie8-georgehttps://github.com/phproberto/joomla-cms/tree/ie8-george?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email

which is 3.3-dev compatible and contains all the changes except the
validate.js fixes. Now we should see if there are some errors there. I'll
do it ASAP.

—
Reply to this email directly or view it on GitHub#3441
.

avatar wilsonge
wilsonge - comment - 17 Apr 2014

VPS ughhh VM even

avatar phproberto
phproberto - comment - 17 Apr 2014

I added more fixes to validate.js ( phproberto@92ea340 ) it took me a lot of time to debug that shit inside the VM :D

avatar wilsonge wilsonge - close - 20 Apr 2014
avatar wilsonge
wilsonge - comment - 20 Apr 2014

Closing this one as well

avatar wilsonge wilsonge - change - 20 Apr 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-04-20 00:26:47
avatar wilsonge wilsonge - close - 20 Apr 2014
avatar wilsonge wilsonge - head_ref_deleted - 20 Apr 2014
avatar kirancheema
kirancheema - comment - 12 Jul 2016

Looks like this has come back in 3.5.1 - html5fallback.js arorun char 1939 has a comma instead of a semi colon

avatar brianteeman
brianteeman - comment - 12 Jul 2016

@kirancheema please open a new issue. No one will see a closed issue

avatar kirancheema
kirancheema - comment - 12 Jul 2016

no worries will do

Add a Comment

Login with GitHub to post a comment