NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
4 Jun 2021

Pull Request for Issue #34363 .

Summary of Changes

Changed padding for page-link when highlight links is active

Testing Instructions

See issue
Run npm ci or npm run build:css

Actual result BEFORE applying this Pull Request

Wrong padding
grafik

Expected result AFTER applying this Pull Request

Padding is correct
grafik

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 4 Jun 2021
avatar drmenzelit drmenzelit - change - 4 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2021
Category Administration Templates (admin) NPM Change
avatar drmenzelit drmenzelit - change - 4 Jun 2021
Title
Restore pagination padding with highlighted links
[4.0] Restore pagination padding with highlighted links
avatar drmenzelit drmenzelit - edited - 4 Jun 2021
avatar sandramay0905 sandramay0905 - test_item - 4 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 4 Jun 2021

I have tested this item successfully on c2424a8

Thanks for creating the pull request @drmenzelit.

Some icons on the sidebar look as having no underline (articles) or only a part underlined (components). Can you have a look on this too or should i make a new issue or is it expected?

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34394.
avatar drmenzelit drmenzelit - change - 4 Jun 2021
The description was changed
avatar drmenzelit drmenzelit - edited - 4 Jun 2021
avatar ChristineWk ChristineWk - test_item - 4 Jun 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 4 Jun 2021

I have tested this item successfully on c2424a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34394.

avatar richard67 richard67 - change - 4 Jun 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 4 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34394.

avatar Quy Quy - change - 4 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-04 15:35:46
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 4 Jun 2021
avatar Quy Quy - merge - 4 Jun 2021
avatar Quy
Quy - comment - 4 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment