I have tested this item ✅ successfully on 8aa4d51

Without pr:

With pr:

@pmleconte we have the same problem in J4, do you think you can make a PR for that too?

we have the same problem in J4, do you think you can make a PR for that too?

Are we no longer merging up changes from 3 to 4 then? I think we are, @wilsonge has been, so this should be fixed in 3 (staging) and then will be automatically (manually) merged up to 4 (4.0-dev) in the future

Oh, I forgot about up-merging... probably I hadn't enough coffee today ;-)

I have tested this item ✅ successfully on 8aa4d51

RTC

Thanks!

Hi,
I updated today my Joomla site to Joomla! 3.9.27 and all values of my custom fields are missing in the backend and consequently, they are not displayed on the frontend. The values are in the database. Does anyone have an idea of the problem?

Thank you

@bettyorganero your question is unrelated to this PR (only a class was added to the rendering of the fields), that was already merged. You can create a new issue or ask in the forum (forum.joomla.org) or in the Q&A section in Discussions (https://github.com/joomla/joomla-cms/discussions)

Hello, I just got into trouble with this change. It totally messed a site, where I used custom fields and there custom CSS class parameters. I was really surprised about the sudden display issues after J!3.9.28 update... So, here is what happened to me:

Possible Issue:

The field render class is already in the fields render layout! With this PR you get two class outputs: One on the default list DD element with class "field entry", and now a second output on the actual field value SPAN element.

For instance, if you use CSS classes from your favorite framework like: well , alert , badge or something similar, you will get a doubled, nested styling. Which messes up the entire display.

IMHO, the current default class output is not optimal. I am not sure at the moment, if there is a better solution. Or if it makes sense to change the fields render layout as well. Actually, I liked the possibility to add a custom class to the entire field output. Only one output at the value would not allow to style the entire appearance. Especially, when you have a multi-value field, you might need to style the surrounding element and all those values at once! So, you get some sort of visual grouping.

I think, this needs some further discussion, would you mind to re-open this issue/PR again?

Thoughts/Ideas:

You may have noticed that the fields render file adds a class "field-entry". Currently all fields get the same class. Wouldn't it make sense to add the unique field ID as a class as well? Maybe also the field ALIAS? That would allow to target each field separately. And the the render class is not needed anymore, except for the VALUE and span.

I think, this needs some further discussion, would you mind to re-open this issue/PR again?

@pepperstreet It's a merged PR so it would not really make sense to re-open it. Would you mind to open a new issue for it?

@pepperstreet Thanks for filing the issue.