User tests: Successful: Unsuccessful:
Pull Request for Issue #32820 .
manage users section is fixed, now any number of columns can be added without worsing UI.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Title |
|
Title |
|
This applies to all views not just users - is that intentional ?
Please try to do this without using inline styles
I can still get one break point where the horizontal scroll bar appears. Is this expected behaviour? If yes I can agree a successful test.
This applies to all views, not just users - is that intentional ?
Please try to do this without using inline styles
I also thought the same but then I applied to all the views because,
The Problem: currently manage users fields have lots of columns which was the fault of overflow as all the columns will not fit under the parent div.
So Why I don't apply this fix only for the manage users part?
here's the reason:
and about Inline CSS, I think that for just a single property Inline is the best, or else I have to declare and apply with class or id
I can still get one break point where the horizontal scroll bar appears. Is this expected behaviour? If yes I can agree a successful test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34387.
can you please describe a bit more, means draw some arrows for your issue on the ss, because I don't get your point.
Just add the overflow: scroll;
here:
joomla-cms/administrator/templates/atum/scss/blocks/_global.scss
Lines 118 to 122 in 1d05105
inline styles are wrong for many reasons. not least of which is that they are very difficult to override
inline styles are wrong for many reasons. not least of which is that they are very difficult to override
Yes, I totally agree. thanks for reminding me.
Just add the
overflow: scroll;
here:joomla-cms/administrator/templates/atum/scss/blocks/_global.scss
Lines 118 to 122 in 1d05105
hello @dgrammatiko, @brianteeman thank you for the help, I have done the changes, now I have to make another PR, or I can edit this PR. sry, it sounds silly but I am currently in the learning stage of the PullRequest Scenario.
You can make new commits to this PR directly. Maybe you should change the title of the PR if you are changing all views and not only users.
Labels |
Added:
?
|
Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) NPM Change |
Labels |
Added:
NPM Resource Changed
|
Title |
|
Check the logs: https://ci.joomla.org/joomla/joomla-cms/44832/1/20
Also please read https://github.com/joomla/joomla-cms/blob/4.0-dev/build/README.md
The order of the declarations is important, lint the file npm run lint:css -- --fix
@drmenzelit, @brianteeman @dgrammatiko I have done the changes, please review!
If there is now overflow then they should not be displayed
@dgrammatiko @brianteeman @drmenzelit can anyone explain the steps/stages in "pull request to be merged".
If there is now overflow then they should not be displayed
Okay, I will try to fix this!
Category | Administration Templates (admin) NPM Change | ⇒ | Administration Templates (admin) |
Labels |
Removed:
NPM Resource Changed
|
Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) NPM Change |
Labels |
Added:
NPM Resource Changed
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-06 00:23:41 |
Closed_By | ⇒ | ThisIsFaar |
I like the scroll-bar solution, why would we hide columns, how do we know they exist if they are hidden on smaller screens?
I have tested this item✅ successfully on be23d92
Works also on list-views for articles, categories.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34387.