NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar ThisIsFaar
ThisIsFaar
3 Jun 2021

Pull Request for Issue #32820 .

Summary of Changes

manage users section is fixed, now any number of columns can be added without worsing UI.

Before Fix

Before

After Fix

After

avatar ThisIsFaar ThisIsFaar - open - 3 Jun 2021
avatar ThisIsFaar ThisIsFaar - change - 3 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2021
Category Administration Templates (admin)
avatar ThisIsFaar ThisIsFaar - change - 4 Jun 2021
Title
User Page fixed
[4.0] Manager User Section overflow fixed
avatar ThisIsFaar ThisIsFaar - edited - 4 Jun 2021
avatar ThisIsFaar ThisIsFaar - change - 4 Jun 2021
Title
[4.0] Manager User Section overflow fixed
[4.0] Manage User Section overflow fixed
avatar ThisIsFaar ThisIsFaar - edited - 4 Jun 2021
avatar sandramay0905 sandramay0905 - test_item - 4 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 4 Jun 2021

I have tested this item successfully on be23d92

Works also on list-views for articles, categories.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34387.

avatar brianteeman
brianteeman - comment - 4 Jun 2021

This applies to all views not just users - is that intentional ?

Please try to do this without using inline styles

avatar Abernyte-Git
Abernyte-Git - comment - 4 Jun 2021

I can still get one break point where the horizontal scroll bar appears. Is this expected behaviour? If yes I can agree a successful test.
screen shot 2021-06-04 at 07 25 14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34387.

avatar ThisIsFaar
ThisIsFaar - comment - 4 Jun 2021

This applies to all views, not just users - is that intentional ?

Please try to do this without using inline styles

I also thought the same but then I applied to all the views because,

The Problem: currently manage users fields have lots of columns which was the fault of overflow as all the columns will not fit under the parent div.

So Why I don't apply this fix only for the manage users part?
here's the reason:

  1. maybe in future updates if any other views also got more columns then this issue will come again in the story.
  2. not only in future updates, let's just take an example If any user using some plugin that will add/update columns for the functionality/required purpose to any of the views, then this issue will also currently faced by those users.

and about Inline CSS, I think that for just a single property Inline is the best, or else I have to declare and apply with class or id

avatar ThisIsFaar
ThisIsFaar - comment - 4 Jun 2021

I can still get one break point where the horizontal scroll bar appears. Is this expected behaviour? If yes I can agree a successful test.
screen shot 2021-06-04 at 07 25 14

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34387.

can you please describe a bit more, means draw some arrows for your issue on the ss, because I don't get your point.

avatar dgrammatiko
dgrammatiko - comment - 4 Jun 2021

Just add the overflow: scroll; here:

.container-main,
.system-debug {
padding-bottom: 50px;
}

avatar brianteeman
brianteeman - comment - 4 Jun 2021

inline styles are wrong for many reasons. not least of which is that they are very difficult to override

avatar ThisIsFaar
ThisIsFaar - comment - 4 Jun 2021

inline styles are wrong for many reasons. not least of which is that they are very difficult to override

Yes, I totally agree. thanks for reminding me.

avatar ThisIsFaar
ThisIsFaar - comment - 4 Jun 2021

Just add the overflow: scroll; here:

.container-main,
.system-debug {
padding-bottom: 50px;
}

hello @dgrammatiko, @brianteeman thank you for the help, I have done the changes, now I have to make another PR, or I can edit this PR. sry, it sounds silly but I am currently in the learning stage of the PullRequest Scenario.

avatar drmenzelit
drmenzelit - comment - 4 Jun 2021

You can make new commits to this PR directly. Maybe you should change the title of the PR if you are changing all views and not only users.

avatar ThisIsFaar ThisIsFaar - change - 4 Jun 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2021
Category Administration Templates (admin) Administration Templates (admin) NPM Change
avatar ThisIsFaar ThisIsFaar - change - 4 Jun 2021
Labels Added: NPM Resource Changed
avatar ThisIsFaar ThisIsFaar - change - 4 Jun 2021
Title
[4.0] Manage User Section overflow fixed
[4.0] Views UI overflow fixed
avatar ThisIsFaar ThisIsFaar - edited - 4 Jun 2021
avatar dgrammatiko
dgrammatiko - comment - 4 Jun 2021

Check the logs: https://ci.joomla.org/joomla/joomla-cms/44832/1/20

Also please read https://github.com/joomla/joomla-cms/blob/4.0-dev/build/README.md

The order of the declarations is important, lint the file npm run lint:css -- --fix

avatar ThisIsFaar
ThisIsFaar - comment - 4 Jun 2021

@drmenzelit, @brianteeman @dgrammatiko I have done the changes, please review!

avatar Quy
Quy - comment - 5 Jun 2021

There are horizontal/vertical scrollbars that don't do anything.

34387-vertical

34387-horizontal

avatar ThisIsFaar
ThisIsFaar - comment - 5 Jun 2021

There are horizontal/vertical scrollbars that don't do anything.

34387-vertical

34387-horizontal

Those horizontal/vertical scrollbars are responsible for the Inner/Main Container to be scrollable flow.

scrollbars reason

avatar brianteeman
brianteeman - comment - 5 Jun 2021

If there is now overflow then they should not be displayed

avatar ThisIsFaar
ThisIsFaar - comment - 5 Jun 2021

@dgrammatiko @brianteeman @drmenzelit can anyone explain the steps/stages in "pull request to be merged".

avatar ThisIsFaar
ThisIsFaar - comment - 5 Jun 2021

If there is now overflow then they should not be displayed

Okay, I will try to fix this!

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2021
Category Administration Templates (admin) NPM Change Administration Templates (admin)
avatar ThisIsFaar ThisIsFaar - change - 6 Jun 2021
Labels Removed: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2021
Category Administration Templates (admin) Administration Templates (admin) NPM Change
avatar ThisIsFaar ThisIsFaar - change - 6 Jun 2021
Labels Added: NPM Resource Changed
avatar ThisIsFaar ThisIsFaar - change - 6 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-06 00:23:41
Closed_By ThisIsFaar
avatar ThisIsFaar ThisIsFaar - close - 6 Jun 2021
avatar ThisIsFaar ThisIsFaar - close - 6 Jun 2021
avatar noxidsoft
noxidsoft - comment - 21 Jul 2021

I like the scroll-bar solution, why would we hide columns, how do we know they exist if they are hidden on smaller screens?

Add a Comment

Login with GitHub to post a comment