[#34383] - [4.0] Dialoges Should be labeled
- Fixed in Code Base
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34383
- Diff
- Krshivam25:arialabel
User tests: Successful: Unsuccessful:
For any container whose contents act as a dialog box (for example, a modal dialog asking the user to make a choice or respond to an action being taken), give it a descriptive label or name, so that assistive technology users can easily discover what its purpose is.
Testing Instructions :
Arrow Indicating Dialog box .
Improvement: Dialog was not accessible before. Whenever we are adding a dialog role we must provide an accessible name for a dialog, which can be done with the aria-label or aria-labelledby attribute.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@Krshivam25 , can you please provide testing instructions for your PR?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.
@jwaisner and @sandramay0905 Just look if the aria-label is added to the dialog after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.
Instead of duplicating the text it is better to add an id to the heading and use aria-labelledby
you write:
<joomla-alert type="info" dismiss="true" class="js-pstats-alert hidden" role="alertdialog" aria-label="<?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?>">
<div class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>
and just like @brianteeman writes, you can prevent double text by another implementation...using aria-labelledby
<joomla-alert type="info" dismiss="true" class="js-pstats-alert hidden" role="alertdialog" aria-labelledby="alert-stats-heading">
<div id="alert-stats-heading" class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>
| Labels |
Added:
?
?
?
|
||
| Labels |
Added:
?
?
Removed: ? ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.
Thank you
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 09:52:42 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
Removed: ? ? |
||
Thanks!
@Krshivam25 can you please provide test instructions?