Same issue for popular articles

I have tested this item ✅ successfully on ac3652c

Updated to include mod_popular

I have tested this item ✅ successfully on 9305f36

Test on mod_latest and mod_popular.

I have tested this item ✅ successfully on 9305f36

RTC

NO! DONT MERGE THIS! ITS WRONG...

Back to pending.

@PhilETaylor Could you provide details about what's wrong?

I screwed up in #34319 and despite three people testing - no one realised.

Actually never mind, Im going to leave my screw up there, and this one can be merged. We dont have many modules with empty state at the moment, and the textSuffix provided is not actually being used (we lost those language strings along the way somehow...)

What should happen - by design - was that the mod_popular empty state should say something like "There are no popular articles at the moment" and the mod_latest should say "There are no latest articles at the moment" - whereas this PR will make them both say "No articles have been created yet" which is technically true, but the idea was to make the empty state module layout generic and that it can be reused, with textPrefix and textSuffix to provide different language strings based on the module purpose.

No idea where the two custom language strings went, but now that they have done, removing the textSuffix from the two modules will do, and my screw up is actually good as it will allow textSuffix to be used correctly in the future if any other modules want to use it.

Please set back to RTC.

RTC

#33472 (comment)

I have removed the module override language strings for the empty state to allow them to inherit from the components empty state language tites.

The layout is still generic and the prefix and suffix can still be used. This PR doesnt effect that

Thanks

thanks