[#34369] - [4.0] Issue with drag & drop ordering
- Closed
- 3 Jun 2021
- Medium
- Build: staging
- # 34369
Hi, I had noticed this bug in beta 8, but given it was nightly build I wasn't sure if there was something wrong with my build so didn't report it. I have tested this issue on a site that was updated from beta, and also a clean install of RC1.
You can drag and drop to change ordering on categories (appears to be fine when categories are all root)
But when you have more category trees, (various levels) Sometimes it doesn't work and js console will show an error. "Cannot read property 'value' of undefined". Once this error appears, it can kill some other functions on the page. (I can't use batch unless I refresh page, See video below. )
I've seen this happen also on menu and plugin pages, but I'm not sure how to reproduce so I won't put it here for now.
Steps to reproduce the issue
Create multiple categories with various levels.
Try to change ordering of categories
(See video below)
Expected result
Should work as expected
Actual result
Will appear "Cannot read property 'value' of undefined" in console error resulting in unable to change order, when category have multiple levels
System information (as much as possible)
Joomla 4 RC1
Mysql 5.7.26
PHP 7.4.2
drag-drop-issue.mp4
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
@dgrammatiko @Fedik Does Dragula allow drag nested elements? From what I see right now, when we drag and parent category to new position, only that parent category is moved, not it's child categories ?
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-03 15:28:17 |
| Closed_By | ⇒ | joomdonation |
@nozaro33 @sandramay0905 Could you please help testing the PR #34375 ? Thanks !
@joomdonation Hey Tuan, going to bed soon will test tomorrow morning! Thanks!
Does Dragula allow drag nested elements?
sorry for delay,
I think it only would work if the children located in the same container with parent, in the same div element,
but we have each item (parent and child) as own element
but we have each item (parent and child) as own element
Yes and also we have a data attribute that indicates the parent of each element. Anyways @joomdonation figured it out
@dgrammatiko @Fedik Actually, I can only fix the ordering issue. The issue with drag and drop nested element is still there. You can see the issue here #34375 (comment) (In J3, we handles it better)
In J3, we handles it better
What's the behaviour in J3? Reload?
What's the behaviour in J3? Reload?
Somehow, in J3, when we drag and drop the parent categories, it's the children categories (actually the whole category tree are moved to new position). And no, it is not reload.
If this is the wrong place please tell me, will open a new issue*).
Similar issue in administrator-modules: Reordering
User StatusbeforeFrontend Linkseems to work, after page-reload the ordering is lost.*) no error in browser-console so i thinks its another, but similar issue.