Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34341] - Make sure the text files are only generated when needed

? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
1 Jun 2021

Pull Request for Issue #34188

Summary of Changes

Make sure the text files (checksums.txt and github_release.txt) are only generated when needed

Testing Instructions

run a build on the current branch with the remote command so without a tag.
php build.php --remote=origin/staging

Actual result BEFORE applying this Pull Request

PHP Warning: Of an Undefined variable $tagVersion

Expected result AFTER applying this Pull Request

No php warning and no generation of files we don't need on none-release builds.

Documentation Changes Required

None

cc @HLeithner @wilsonge

avatar zero-24 zero-24 - open - 1 Jun 2021
avatar zero-24 zero-24 - change - 1 Jun 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2021
Category ⇒ Repository
avatar PhilETaylor
PhilETaylor - comment - 3 Jun 2021

weblink issue with

php build.php --remote=origin/4.0-dev

Start build for remote origin/4.0-dev.
Delete old release folder.
Copy the files from the git repository.
Create list of changed files from git repository for version 4.0.0-rc2-dev.
Delete folders not included in packages.
Build full package files.
mv: rename administrator/manifests/packages/pkg_weblinks.xml to ../pkg_weblinks.xml: No such file or directory
Build full update package.
mv: rename ../pkg_weblinks.xml to administrator/manifests/packages/pkg_weblinks.xml: No such file or directory
Build of version 4.0.0-rc2-dev complete!
avatar PhilETaylor PhilETaylor - test_item - 3 Jun 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 3 Jun 2021

I have tested this item ✅ successfully on d933c88

fixes the tagVersion issue, but see the weblink one when building 4.0-dev

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34341.

avatar zero-24
zero-24 - comment - 11 Jun 2021

fixes the tagVersion issue, but see the weblink one when building 4.0-dev

Yes. The build script for 4.0 does not include the weblink stuff anymore and also has some other stuff as the build is a bit different than the build of 3.x. So to build 4.0-dev we should use the 4.0-dev build script :)

@HLeithner please have a look here and get this a merge please :)

avatar HLeithner HLeithner - change - 11 Jun 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-06-11 12:18:32
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 11 Jun 2021
avatar HLeithner HLeithner - merge - 11 Jun 2021
avatar HLeithner
HLeithner - comment - 11 Jun 2021

thanks

Add a Comment

Login with GitHub to post a comment