? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
1 Jun 2021

Code review

CategoryFactoryInterface is used in the constructor however that class is not defined as this file is in the namespace Joomla\Component\Tags\Site\Service and CategoryFactoryInterface is in the namespace Joomla\CMS\Categories

So we need to import the class to prevent fatal errors if someone ever used the constructor and provided a valid value for $categoryFactory

avatar PhilETaylor PhilETaylor - open - 1 Jun 2021
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2021
Category com_tags Front End
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
Title
Prevent fatal error by importing use CategoryFactoryInterface
[4] Prevent fatal error by importing use CategoryFactoryInterface
avatar PhilETaylor PhilETaylor - edited - 1 Jun 2021
avatar wilsonge wilsonge - change - 1 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-01 15:08:03
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Jun 2021
avatar wilsonge wilsonge - merge - 1 Jun 2021
avatar wilsonge
wilsonge - comment - 1 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment