? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
1 Jun 2021

Pull Request for Issue #34322 reverts and improves on #34246

Summary of Changes

In Joomla 4 we have two types of Warning Alert rendering.

We have bootstrap with standard alert alert-warning classes (An example: Field notes. Login to Joomla admin and then go to User Menu -> Edit account -> Joomla API Token)

We also have joomla-alert custom element. (An example: Login to Joomla admin with a wrong user and pass and see the warning)

After the changes in #34246 the custom element looked good, but the bootstrap element looked "too yellow"

*"looked good". = Bright yellow border and optional left panel and "muddy" text
*"too yellow" = Bright yellow text and bright yellow border and optional left panel

Testing Instructions

Using the two example above - check them before and after applying this PR

Remember to rebuild your CSS with npm run build:css after applying the PR, and remember browsers aggressively cache css files.

Actual result BEFORE applying this Pull Request

Custom Elements:

Screenshot 2021-06-01 at 11 08 07

Bootstrap Elements:

Screenshot 2021-06-01 at 11 09 38

Expected result AFTER applying this Pull Request

Custom Elements:

Screenshot 2021-06-01 at 11 08 07

Bootstrap Elements:

Screenshot 2021-06-01 at 11 07 43

Contrast

The muddy color on the yellow background gives a contrast ratio of 4.68 which is good enough for AA but not the 7.0 needed for AAA which would require the muddy cooler to be #745000

Screenshot 2021-06-01 at 11 17 47

avatar PhilETaylor PhilETaylor - open - 1 Jun 2021
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2021
Category Administration Templates (admin) NPM Change
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jun 2021
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jun 2021
avatar PhilETaylor PhilETaylor - change - 1 Jun 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jun 2021
avatar Kostelano
Kostelano - comment - 1 Jun 2021

The cross "CLOSE" appears to be a foreign body in this color combination.

As far as I remember, in other notifications the cross corresponds to the border and the text inside. In any case, it looks organic. There is no.

avatar PhilETaylor
PhilETaylor - comment - 1 Jun 2021

I have not made any changes to the cross, this PR doesnt address the cross at all, so Im unsure what your comment, on this PR, relates to.

avatar Kostelano
Kostelano - comment - 1 Jun 2021

I have seen. Sorry if I touched on subtle feelings :).

I wrote about this because I see screenshots of the notification where the cross "does not look" together with the notification itself in the complex. And maybe the color change for the border / text / cross should be considered together.

avatar PhilETaylor
PhilETaylor - comment - 1 Jun 2021

I have seen. Sorry if I touched on subtle feelings :).

It has nothing to do with feelings. The Cross/Close has nothing to do with this PR. The Cross/Close has only just been changed by this other PR yesterday #34246 (comment)

avatar regularlabs
regularlabs - comment - 1 Jun 2021

Tested successfully

avatar Krshivam25 Krshivam25 - test_item - 2 Jun 2021 - Tested successfully
avatar Krshivam25
Krshivam25 - comment - 2 Jun 2021

I have tested this item successfully on f64ddf9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34328.

avatar Quy Quy - alter_testresult - 2 Jun 2021 - regularlabs: Tested successfully
avatar Quy Quy - change - 2 Jun 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 2 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34328.

avatar wilsonge wilsonge - close - 3 Jun 2021
avatar wilsonge wilsonge - merge - 3 Jun 2021
avatar wilsonge wilsonge - change - 3 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-03 14:47:55
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 3 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment