User tests: Successful: Unsuccessful:
Pull Request for Issue #34322 reverts and improves on #34246
In Joomla 4 we have two types of Warning Alert rendering.
We have bootstrap with standard alert alert-warning
classes (An example: Field notes. Login to Joomla admin and then go to User Menu -> Edit account -> Joomla API Token)
We also have joomla-alert
custom element. (An example: Login to Joomla admin with a wrong user and pass and see the warning)
After the changes in #34246 the custom element looked good, but the bootstrap element looked "too yellow"
*"looked good". = Bright yellow border and optional left panel and "muddy" text
*"too yellow" = Bright yellow text and bright yellow border and optional left panel
Using the two example above - check them before and after applying this PR
Remember to rebuild your CSS with npm run build:css
after applying the PR, and remember browsers aggressively cache css files.
Custom Elements:
Bootstrap Elements:
Custom Elements:
Bootstrap Elements:
The muddy color on the yellow background gives a contrast ratio of 4.68 which is good enough for AA but not the 7.0 needed for AAA which would require the muddy cooler to be #745000
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
I have not made any changes to the cross, this PR doesnt address the cross at all, so Im unsure what your comment, on this PR, relates to.
I have seen. Sorry if I touched on subtle feelings :).
I wrote about this because I see screenshots of the notification where the cross "does not look" together with the notification itself in the complex. And maybe the color change for the border / text / cross should be considered together.
I have seen. Sorry if I touched on subtle feelings :).
It has nothing to do with feelings. The Cross/Close has nothing to do with this PR. The Cross/Close has only just been changed by this other PR yesterday #34246 (comment)
Tested successfully
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-03 14:47:55 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
The cross "CLOSE" appears to be a foreign body in this color combination.
As far as I remember, in other notifications the cross corresponds to the border and the text inside. In any case, it looks organic. There is no.