Feeling Lucky
?
?
[#34316] - [4] The Download Key is missing color
- Fixed in Code Base
- 1 Jun 2021
- Medium
- Build: 4.0-dev
- # 34316
- Diff
- PhilETaylor:downloadkeycolor
User tests: Successful: Unsuccessful:
forked from #34312 (comment)
Summary of Changes
If the quick icon is going to be red/danger and a missing download key is "that level" of feedback, then it should be consistently used "at that level" = E.g Danger/Error/Red level
Testing Instructions
Install a 3PD that needs a download key
Visit update sites
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
PhilETaylor
- comment
- 31 May 2021
We certainly do use a red badge elsewhere for "things"
Quy
- comment
- 31 May 2021
text-white is not necessary because it is declared in badge.
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 31 May 2021
Thanks.
Quy
- comment
- 31 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34316.
YatharthVyas
- comment
- 1 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34316.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 1 Jun 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34316.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-01 12:56:22 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 1 Jun 2021
Thanks!
@PhilETaylor I remember that yellow badge colour from other places but don't remember the red one now. Are we consistent with this PR? Where else do we already use such red badges?